Fixed warnings - strict-prototypes #115
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
| @@ -103,7 +103,7 @@ | |||
| * This is the preferred method over calling the underlying function directly. | |||
| */ | |||
| # define TRACETOOLS_TRACEPOINT_ENABLED(event_name) \ | |||
| ros_trace_enabled_ ## event_name() | |||
| ros_trace_enabled_ ## event_name(void) | |||
There was a problem hiding this comment.
This is not going to work (see build failures in GitHub CI), because these macros are used for both declaration and implementation+call. I'd need to split them up.
There was a problem hiding this comment.
If you wanted to, you could split out the other changes (or remove the changes involving macros above from this PR), since they should be fine:
ros_trace_compile_status()in this filetracetools/src/status_tool.ctracetools/src/tracetools.c
Then I can look into dealing with the changes to macros separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are new warnings on CI related with this compiler option
strict-prototypeshttps://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/1860/gcc/new/