Add workaround for building on Fedora #4795
Conversation
This introduces a more or less hacky workaround. I am not sure if these system variables are set to the correct values. I think this should be added anyway, because it helped me build on Fedora. Signed-off-by: Ted Zards <[email protected]>
|
This is about qt_gui_cpp not building on Fedora without those system variables being set. It just has to be set for building that package with |
| export RPM_PACKAGE_RELEASE=1.0 | ||
| export RPM_PACKAGE_VERSION=1.0 | ||
| export RPM_PACKAGE_NAME=qt_gui_cpp |
There was a problem hiding this comment.
i am not sure if these environmental variables are statically assigned like this since those are configured for each pacakge description? but this is just a source build tutorial, not creating the rpm package, so that would be okay?
There was a problem hiding this comment.
I am not sure - I just copied what was done in the issue linked (ros2/ros2#1491) since it worked for me. I was also confused by the name being that package.
There was a problem hiding this comment.
i think this is obviously the problem with rpm configuration, https://bugzilla.redhat.com/show_bug.cgi?id=2043092 other language such as ruby also meets this problem?
IMO, having this work-around in this tutorial would be okay, so that ROS 2 users with RHEL do not need to search the work-around.
|
Just as an FYI, @cottsay and I took a look at this, and this workaround is currently necessary on Fedora. That said, this is 100% a bug in the Fedora packaging of SIP. We are looking into whether we can fix that bug in the upstream Fedora packages so we don't need this workaround. |
|
Here's the upstream ticket I filed: https://bugzilla.redhat.com/2317847 |
This introduces a more or less hacky workaround. I am not sure if these system variables are set to the correct values.
I think this should be added anyway, because it helped me build on Fedora.