-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move package.xml format 1 to 2 migration to its own page #4778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <[email protected]>
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/11118737215/artifacts/1998919526. To view the resulting site:
|
fujitatomoya
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor nit, lgtm
Signed-off-by: Shane Loretz <[email protected]>
ahcorde
approved these changes
Oct 1, 2024
ahcorde
added
the
backport-all
backport at reviewers discretion; from rolling to all versions
label
Oct 1, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Shane Loretz <[email protected]> (cherry picked from commit 12cc86a)
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Shane Loretz <[email protected]> (cherry picked from commit 12cc86a)
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Shane Loretz <[email protected]> (cherry picked from commit 12cc86a)
ahcorde
pushed a commit
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Shane Loretz <[email protected]> (cherry picked from commit 12cc86a) Co-authored-by: Shane Loretz <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Shane Loretz <[email protected]> (cherry picked from commit 12cc86a) Co-authored-by: Shane Loretz <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Shane Loretz <[email protected]> (cherry picked from commit 12cc86a) Co-authored-by: Shane Loretz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the guide on migrating
package.xml
files to format 2 into it's own page. I also made some changes to it.<depend>
to the bottom to catch simplifications that can be done after the<run_depends>
are replaced.. note::
for theCMakeLists.txt
comment