Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move package.xml format 1 to 2 migration to its own page #4778

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Oct 1, 2024

This moves the guide on migrating package.xml files to format 2 into it's own page. I also made some changes to it.

  • Added introduction, prerequisites, and test sections
  • Made section headings more descriptive
  • Moved <depend> to the bottom to catch simplifications that can be done after the <run_depends> are replaced
  • Used .. note:: for the CMakeLists.txt comment
  • Use active voice and second person perspective

@sloretz sloretz self-assigned this Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/11118737215/artifacts/1998919526.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4778/index.html in your favorite browser

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor nit, lgtm

@ahcorde ahcorde added the backport-all backport at reviewers discretion; from rolling to all versions label Oct 1, 2024
@ahcorde ahcorde merged commit 12cc86a into rolling Oct 1, 2024
4 checks passed
@ahcorde ahcorde deleted the sloretz__package.xml_separate_page branch October 1, 2024 11:01
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
ahcorde pushed a commit that referenced this pull request Oct 1, 2024
Signed-off-by: Shane Loretz <[email protected]>
(cherry picked from commit 12cc86a)

Co-authored-by: Shane Loretz <[email protected]>
ahcorde pushed a commit that referenced this pull request Oct 1, 2024
Signed-off-by: Shane Loretz <[email protected]>
(cherry picked from commit 12cc86a)

Co-authored-by: Shane Loretz <[email protected]>
ahcorde pushed a commit that referenced this pull request Oct 1, 2024
Signed-off-by: Shane Loretz <[email protected]>
(cherry picked from commit 12cc86a)

Co-authored-by: Shane Loretz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants