Sony's task for Iron Release. #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya.Fujita <[email protected]>
fujitatomoya
commented
Oct 13, 2022
source/The-ROS2-Project/Roadmap.rst
Outdated
| @@ -67,6 +67,14 @@ If you'd like to take on one of these tasks, please :doc:`get in touch with us < | |||
| - Medium | |||
| - Open Robotics | |||
| - Q1 2023 | |||
| * - ContentFiltering fallback in rcl | |||
There was a problem hiding this comment.
see ros2/design#282
source/The-ROS2-Project/Roadmap.rst
Outdated
| - Large | ||
| - Sony Group Corporation | ||
| - Q1 2023 | ||
| * - on_pub/sub_matched callback support |
There was a problem hiding this comment.
see ros2/rmw#330
clalancette
added
the
backport-all
Signed-off-by: Chris Lalancette <[email protected]>
clalancette
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Thanks @fujitatomoya ! I've made a couple of small changes here:
- I rearranged things to put the company name in alphabetical order.
- I added links that you helpfully provided directly to the table.
With that, this looks good to me so I'll merge it.
delete-merged-branch
bot
deleted the
topic/20221013-sony-iron-development
branch
mergify bot
pushed a commit
that referenced
this pull request
Oct 14, 2022
* Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 8771452)
mergify bot
pushed a commit
that referenced
this pull request
Oct 14, 2022
* Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 8771452)
This was referenced Oct 14, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 14, 2022
* Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 8771452)
clalancette
pushed a commit
that referenced
this pull request
Oct 14, 2022
* Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 8771452) Co-authored-by: Tomoya Fujita <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Oct 14, 2022
* Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 8771452) Co-authored-by: Tomoya Fujita <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Oct 14, 2022
* Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 8771452) Co-authored-by: Tomoya Fujita <[email protected]>
ygoumaz
added a commit
to cyberbotics/ros2_documentation
that referenced
this pull request
Nov 2, 2022
commit 72effa7 Author: Luke Schmitt <[email protected]> Date: Tue Nov 1 17:26:25 2022 -0500 Fix list formatting on Contact page (ros2#3153) commit dcd066f Author: Dan Zimmerman <[email protected]> Date: Tue Nov 1 16:29:34 2022 -0400 Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (ros2#3143) * Note milliseconds on API Concepts page * Add units and types to About Logging page Co-authored-by: dan <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 375b6cf Author: definitelyuncertain <[email protected]> Date: Fri Oct 28 14:30:22 2022 -0500 Change to mention explicit requirement for folder names for .msg and .srv files (ros2#3144) * Change to mention explicit requirement for folder names for msg and srv files From ros2/tutorials#29 * fix typo Co-authored-by: Tomoya Fujita <[email protected]> * fix rst formatting Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit da871ef Author: Sergei Sergienko <[email protected]> Date: Thu Oct 27 17:20:06 2022 +0300 fix link to Gazebo-ROS2 bridge + CLI examples (ros2#3139) * fix link to Gazebo-ROS2 bridge + CLI examples Co-authored-by: Chris Lalancette <[email protected]> commit e19c9b5 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 16:31:21 2022 -0400 Update the language to match the source code. (ros2#3135) Fallout from ros2#2865 Signed-off-by: Chris Lalancette <[email protected]> commit a5910a1 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 08:38:36 2022 -0400 Shorten the Windows build-from-source path. (ros2#3130) * Shorten the Windows build-from-source path. This is to keep the total length down below the 260 character limit imposed by Windows by default. Signed-off-by: Chris Lalancette <[email protected]> commit 8225686 Author: Chris Lalancette <[email protected]> Date: Mon Oct 24 08:30:37 2022 -0400 Fix up the variable name in the traveling in time (C++) tutorial. (ros2#3115) This is just to match what is in the code in the upstream repository. Signed-off-by: Chris Lalancette <[email protected]> commit 87ab121 Author: Ian Colwell <[email protected]> Date: Fri Oct 21 11:07:30 2022 -0400 Update default WORKING_DIRECTORY for ament_add_gtest() (ros2#3117) commit 87bf20a Author: chianfern <[email protected]> Date: Tue Oct 18 21:36:57 2022 +0800 Add ParameterDescriptor to 'Using parameters in a class (C++)' (ros2#2865) * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial. Signed-off-by: Tan Chian Fern <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 77646ce Author: George Stavrinos <[email protected]> Date: Tue Oct 18 15:29:37 2022 +0300 Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (ros2#3107) commit 1d24955 Author: Chris Lalancette <[email protected]> Date: Mon Oct 17 14:06:52 2022 -0400 Monitor parameter changes: Add note to save callback handle (ros2#3102) Signed-off-by: Chris Lalancette <[email protected]> commit 8910a80 Author: David V. Lu!! <[email protected]> Date: Fri Oct 14 09:56:14 2022 -0400 Some testing basics (ros2#3084) * Some testing basics Signed-off-by: David V. Lu <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 8771452 Author: Tomoya Fujita <[email protected]> Date: Fri Oct 14 05:34:20 2022 -0700 Sony's task for Iron Release. (ros2#3089) * Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 2ea9e7d Author: Yannick Goumaz <[email protected]> Date: Fri Oct 14 14:23:13 2022 +0200 Update Setting-up a Robot Simulation (Webots) tutorial (ros2#3090) * Update intro to WSL * Update world with declarations * Add supervisor node and environment var * Update tutorial with explanations Co-authored-by: ad-daniel <[email protected]> commit 0390a50 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Date: Thu Oct 13 13:42:30 2022 -0400 fix unresolved package requirement to install Humble on Ubuntu 20.04 (ros2#3086) (ros2#3088) * fix command to install humble on Ubuntu 20.04 Co-authored-by: paolo.dimasi <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 5626af9) Co-authored-by: Paolo Dimasi <[email protected]>
ygoumaz
added a commit
to cyberbotics/ros2_documentation
that referenced
this pull request
Nov 2, 2022
commit 72effa7 Author: Luke Schmitt <[email protected]> Date: Tue Nov 1 17:26:25 2022 -0500 Fix list formatting on Contact page (ros2#3153) commit dcd066f Author: Dan Zimmerman <[email protected]> Date: Tue Nov 1 16:29:34 2022 -0400 Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (ros2#3143) * Note milliseconds on API Concepts page * Add units and types to About Logging page Co-authored-by: dan <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 375b6cf Author: definitelyuncertain <[email protected]> Date: Fri Oct 28 14:30:22 2022 -0500 Change to mention explicit requirement for folder names for .msg and .srv files (ros2#3144) * Change to mention explicit requirement for folder names for msg and srv files From ros2/tutorials#29 * fix typo Co-authored-by: Tomoya Fujita <[email protected]> * fix rst formatting Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit da871ef Author: Sergei Sergienko <[email protected]> Date: Thu Oct 27 17:20:06 2022 +0300 fix link to Gazebo-ROS2 bridge + CLI examples (ros2#3139) * fix link to Gazebo-ROS2 bridge + CLI examples Co-authored-by: Chris Lalancette <[email protected]> commit e19c9b5 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 16:31:21 2022 -0400 Update the language to match the source code. (ros2#3135) Fallout from ros2#2865 Signed-off-by: Chris Lalancette <[email protected]> commit a5910a1 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 08:38:36 2022 -0400 Shorten the Windows build-from-source path. (ros2#3130) * Shorten the Windows build-from-source path. This is to keep the total length down below the 260 character limit imposed by Windows by default. Signed-off-by: Chris Lalancette <[email protected]> commit 8225686 Author: Chris Lalancette <[email protected]> Date: Mon Oct 24 08:30:37 2022 -0400 Fix up the variable name in the traveling in time (C++) tutorial. (ros2#3115) This is just to match what is in the code in the upstream repository. Signed-off-by: Chris Lalancette <[email protected]> commit 87ab121 Author: Ian Colwell <[email protected]> Date: Fri Oct 21 11:07:30 2022 -0400 Update default WORKING_DIRECTORY for ament_add_gtest() (ros2#3117) commit 87bf20a Author: chianfern <[email protected]> Date: Tue Oct 18 21:36:57 2022 +0800 Add ParameterDescriptor to 'Using parameters in a class (C++)' (ros2#2865) * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial. Signed-off-by: Tan Chian Fern <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 77646ce Author: George Stavrinos <[email protected]> Date: Tue Oct 18 15:29:37 2022 +0300 Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (ros2#3107) commit 1d24955 Author: Chris Lalancette <[email protected]> Date: Mon Oct 17 14:06:52 2022 -0400 Monitor parameter changes: Add note to save callback handle (ros2#3102) Signed-off-by: Chris Lalancette <[email protected]> commit 8910a80 Author: David V. Lu!! <[email protected]> Date: Fri Oct 14 09:56:14 2022 -0400 Some testing basics (ros2#3084) * Some testing basics Signed-off-by: David V. Lu <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 8771452 Author: Tomoya Fujita <[email protected]> Date: Fri Oct 14 05:34:20 2022 -0700 Sony's task for Iron Release. (ros2#3089) * Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 2ea9e7d Author: Yannick Goumaz <[email protected]> Date: Fri Oct 14 14:23:13 2022 +0200 Update Setting-up a Robot Simulation (Webots) tutorial (ros2#3090) * Update intro to WSL * Update world with declarations * Add supervisor node and environment var * Update tutorial with explanations Co-authored-by: ad-daniel <[email protected]> commit 0390a50 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Date: Thu Oct 13 13:42:30 2022 -0400 fix unresolved package requirement to install Humble on Ubuntu 20.04 (ros2#3086) (ros2#3088) * fix command to install humble on Ubuntu 20.04 Co-authored-by: paolo.dimasi <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 5626af9) Co-authored-by: Paolo Dimasi <[email protected]>
audrow
pushed a commit
that referenced
this pull request
Feb 13, 2023
…3317) * Update intro to WSL * Revert "Update intro to WSL" This reverts commit 52a52d0. * Update intro to wsl * Remove windows tabs * Add windows WSL tab for extern controller code * Clean tutorial * Update world with declarations * Add supervisor node and environment var * Add ros2supervisorlauncher node creation in launch files * add env variable for linux * Update tutorial with explanations * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: ad-daniel <[email protected]> * include correct file for supervisor part * Add WEBOTS_CONTROLLER_URL wsl infos * cleanup * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Remove confusing sentence * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Squashed commit of the following: commit 72effa7 Author: Luke Schmitt <[email protected]> Date: Tue Nov 1 17:26:25 2022 -0500 Fix list formatting on Contact page (#3153) commit dcd066f Author: Dan Zimmerman <[email protected]> Date: Tue Nov 1 16:29:34 2022 -0400 Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143) * Note milliseconds on API Concepts page * Add units and types to About Logging page Co-authored-by: dan <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 375b6cf Author: definitelyuncertain <[email protected]> Date: Fri Oct 28 14:30:22 2022 -0500 Change to mention explicit requirement for folder names for .msg and .srv files (#3144) * Change to mention explicit requirement for folder names for msg and srv files From ros2/tutorials#29 * fix typo Co-authored-by: Tomoya Fujita <[email protected]> * fix rst formatting Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit da871ef Author: Sergei Sergienko <[email protected]> Date: Thu Oct 27 17:20:06 2022 +0300 fix link to Gazebo-ROS2 bridge + CLI examples (#3139) * fix link to Gazebo-ROS2 bridge + CLI examples Co-authored-by: Chris Lalancette <[email protected]> commit e19c9b5 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 16:31:21 2022 -0400 Update the language to match the source code. (#3135) Fallout from #2865 Signed-off-by: Chris Lalancette <[email protected]> commit a5910a1 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 08:38:36 2022 -0400 Shorten the Windows build-from-source path. (#3130) * Shorten the Windows build-from-source path. This is to keep the total length down below the 260 character limit imposed by Windows by default. Signed-off-by: Chris Lalancette <[email protected]> commit 8225686 Author: Chris Lalancette <[email protected]> Date: Mon Oct 24 08:30:37 2022 -0400 Fix up the variable name in the traveling in time (C++) tutorial. (#3115) This is just to match what is in the code in the upstream repository. Signed-off-by: Chris Lalancette <[email protected]> commit 87ab121 Author: Ian Colwell <[email protected]> Date: Fri Oct 21 11:07:30 2022 -0400 Update default WORKING_DIRECTORY for ament_add_gtest() (#3117) commit 87bf20a Author: chianfern <[email protected]> Date: Tue Oct 18 21:36:57 2022 +0800 Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865) * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial. Signed-off-by: Tan Chian Fern <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 77646ce Author: George Stavrinos <[email protected]> Date: Tue Oct 18 15:29:37 2022 +0300 Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107) commit 1d24955 Author: Chris Lalancette <[email protected]> Date: Mon Oct 17 14:06:52 2022 -0400 Monitor parameter changes: Add note to save callback handle (#3102) Signed-off-by: Chris Lalancette <[email protected]> commit 8910a80 Author: David V. Lu!! <[email protected]> Date: Fri Oct 14 09:56:14 2022 -0400 Some testing basics (#3084) * Some testing basics Signed-off-by: David V. Lu <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 8771452 Author: Tomoya Fujita <[email protected]> Date: Fri Oct 14 05:34:20 2022 -0700 Sony's task for Iron Release. (#3089) * Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 2ea9e7d Author: Yannick Goumaz <[email protected]> Date: Fri Oct 14 14:23:13 2022 +0200 Update Setting-up a Robot Simulation (Webots) tutorial (#3090) * Update intro to WSL * Update world with declarations * Add supervisor node and environment var * Update tutorial with explanations Co-authored-by: ad-daniel <[email protected]> commit 0390a50 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Date: Thu Oct 13 13:42:30 2022 -0400 fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088) * fix command to install humble on Ubuntu 20.04 Co-authored-by: paolo.dimasi <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 5626af9) Co-authored-by: Paolo Dimasi <[email protected]> * Update Webots.rst * Update intro to wsl * Remove windows tabs * Add windows WSL tab for extern controller code * Clean tutorial * Add ros2supervisorlauncher node creation in launch files * Update intro to WSL * Update tutorial with explanations * include correct file for supervisor part * Add WEBOTS_CONTROLLER_URL wsl infos * cleanup * Remove confusing sentence * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Squashed commit of the following: commit 72effa7 Author: Luke Schmitt <[email protected]> Date: Tue Nov 1 17:26:25 2022 -0500 Fix list formatting on Contact page (#3153) commit dcd066f Author: Dan Zimmerman <[email protected]> Date: Tue Nov 1 16:29:34 2022 -0400 Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143) * Note milliseconds on API Concepts page * Add units and types to About Logging page Co-authored-by: dan <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 375b6cf Author: definitelyuncertain <[email protected]> Date: Fri Oct 28 14:30:22 2022 -0500 Change to mention explicit requirement for folder names for .msg and .srv files (#3144) * Change to mention explicit requirement for folder names for msg and srv files From ros2/tutorials#29 * fix typo Co-authored-by: Tomoya Fujita <[email protected]> * fix rst formatting Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit da871ef Author: Sergei Sergienko <[email protected]> Date: Thu Oct 27 17:20:06 2022 +0300 fix link to Gazebo-ROS2 bridge + CLI examples (#3139) * fix link to Gazebo-ROS2 bridge + CLI examples Co-authored-by: Chris Lalancette <[email protected]> commit e19c9b5 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 16:31:21 2022 -0400 Update the language to match the source code. (#3135) Fallout from #2865 Signed-off-by: Chris Lalancette <[email protected]> commit a5910a1 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 08:38:36 2022 -0400 Shorten the Windows build-from-source path. (#3130) * Shorten the Windows build-from-source path. This is to keep the total length down below the 260 character limit imposed by Windows by default. Signed-off-by: Chris Lalancette <[email protected]> commit 8225686 Author: Chris Lalancette <[email protected]> Date: Mon Oct 24 08:30:37 2022 -0400 Fix up the variable name in the traveling in time (C++) tutorial. (#3115) This is just to match what is in the code in the upstream repository. Signed-off-by: Chris Lalancette <[email protected]> commit 87ab121 Author: Ian Colwell <[email protected]> Date: Fri Oct 21 11:07:30 2022 -0400 Update default WORKING_DIRECTORY for ament_add_gtest() (#3117) commit 87bf20a Author: chianfern <[email protected]> Date: Tue Oct 18 21:36:57 2022 +0800 Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865) * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial. Signed-off-by: Tan Chian Fern <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 77646ce Author: George Stavrinos <[email protected]> Date: Tue Oct 18 15:29:37 2022 +0300 Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107) commit 1d24955 Author: Chris Lalancette <[email protected]> Date: Mon Oct 17 14:06:52 2022 -0400 Monitor parameter changes: Add note to save callback handle (#3102) Signed-off-by: Chris Lalancette <[email protected]> commit 8910a80 Author: David V. Lu!! <[email protected]> Date: Fri Oct 14 09:56:14 2022 -0400 Some testing basics (#3084) * Some testing basics Signed-off-by: David V. Lu <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 8771452 Author: Tomoya Fujita <[email protected]> Date: Fri Oct 14 05:34:20 2022 -0700 Sony's task for Iron Release. (#3089) * Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 2ea9e7d Author: Yannick Goumaz <[email protected]> Date: Fri Oct 14 14:23:13 2022 +0200 Update Setting-up a Robot Simulation (Webots) tutorial (#3090) * Update intro to WSL * Update world with declarations * Add supervisor node and environment var * Update tutorial with explanations Co-authored-by: ad-daniel <[email protected]> commit 0390a50 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Date: Thu Oct 13 13:42:30 2022 -0400 fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088) * fix command to install humble on Ubuntu 20.04 Co-authored-by: paolo.dimasi <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 5626af9) Co-authored-by: Paolo Dimasi <[email protected]> * Update Webots.rst * Update Webots.rst * Remove trailing white spaces * Update to VM and no supervisor * Remove wrong text * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> --------- Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Olivier Michel <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
…3317) * Update intro to WSL * Revert "Update intro to WSL" This reverts commit 52a52d0. * Update intro to wsl * Remove windows tabs * Add windows WSL tab for extern controller code * Clean tutorial * Update world with declarations * Add supervisor node and environment var * Add ros2supervisorlauncher node creation in launch files * add env variable for linux * Update tutorial with explanations * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: ad-daniel <[email protected]> * include correct file for supervisor part * Add WEBOTS_CONTROLLER_URL wsl infos * cleanup * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Remove confusing sentence * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Squashed commit of the following: commit 72effa7 Author: Luke Schmitt <[email protected]> Date: Tue Nov 1 17:26:25 2022 -0500 Fix list formatting on Contact page (#3153) commit dcd066f Author: Dan Zimmerman <[email protected]> Date: Tue Nov 1 16:29:34 2022 -0400 Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143) * Note milliseconds on API Concepts page * Add units and types to About Logging page Co-authored-by: dan <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 375b6cf Author: definitelyuncertain <[email protected]> Date: Fri Oct 28 14:30:22 2022 -0500 Change to mention explicit requirement for folder names for .msg and .srv files (#3144) * Change to mention explicit requirement for folder names for msg and srv files From ros2/tutorials#29 * fix typo Co-authored-by: Tomoya Fujita <[email protected]> * fix rst formatting Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit da871ef Author: Sergei Sergienko <[email protected]> Date: Thu Oct 27 17:20:06 2022 +0300 fix link to Gazebo-ROS2 bridge + CLI examples (#3139) * fix link to Gazebo-ROS2 bridge + CLI examples Co-authored-by: Chris Lalancette <[email protected]> commit e19c9b5 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 16:31:21 2022 -0400 Update the language to match the source code. (#3135) Fallout from #2865 Signed-off-by: Chris Lalancette <[email protected]> commit a5910a1 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 08:38:36 2022 -0400 Shorten the Windows build-from-source path. (#3130) * Shorten the Windows build-from-source path. This is to keep the total length down below the 260 character limit imposed by Windows by default. Signed-off-by: Chris Lalancette <[email protected]> commit 8225686 Author: Chris Lalancette <[email protected]> Date: Mon Oct 24 08:30:37 2022 -0400 Fix up the variable name in the traveling in time (C++) tutorial. (#3115) This is just to match what is in the code in the upstream repository. Signed-off-by: Chris Lalancette <[email protected]> commit 87ab121 Author: Ian Colwell <[email protected]> Date: Fri Oct 21 11:07:30 2022 -0400 Update default WORKING_DIRECTORY for ament_add_gtest() (#3117) commit 87bf20a Author: chianfern <[email protected]> Date: Tue Oct 18 21:36:57 2022 +0800 Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865) * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial. Signed-off-by: Tan Chian Fern <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 77646ce Author: George Stavrinos <[email protected]> Date: Tue Oct 18 15:29:37 2022 +0300 Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107) commit 1d24955 Author: Chris Lalancette <[email protected]> Date: Mon Oct 17 14:06:52 2022 -0400 Monitor parameter changes: Add note to save callback handle (#3102) Signed-off-by: Chris Lalancette <[email protected]> commit 8910a80 Author: David V. Lu!! <[email protected]> Date: Fri Oct 14 09:56:14 2022 -0400 Some testing basics (#3084) * Some testing basics Signed-off-by: David V. Lu <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 8771452 Author: Tomoya Fujita <[email protected]> Date: Fri Oct 14 05:34:20 2022 -0700 Sony's task for Iron Release. (#3089) * Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 2ea9e7d Author: Yannick Goumaz <[email protected]> Date: Fri Oct 14 14:23:13 2022 +0200 Update Setting-up a Robot Simulation (Webots) tutorial (#3090) * Update intro to WSL * Update world with declarations * Add supervisor node and environment var * Update tutorial with explanations Co-authored-by: ad-daniel <[email protected]> commit 0390a50 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Date: Thu Oct 13 13:42:30 2022 -0400 fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088) * fix command to install humble on Ubuntu 20.04 Co-authored-by: paolo.dimasi <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 5626af9) Co-authored-by: Paolo Dimasi <[email protected]> * Update Webots.rst * Update intro to wsl * Remove windows tabs * Add windows WSL tab for extern controller code * Clean tutorial * Add ros2supervisorlauncher node creation in launch files * Update intro to WSL * Update tutorial with explanations * include correct file for supervisor part * Add WEBOTS_CONTROLLER_URL wsl infos * cleanup * Remove confusing sentence * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Squashed commit of the following: commit 72effa7 Author: Luke Schmitt <[email protected]> Date: Tue Nov 1 17:26:25 2022 -0500 Fix list formatting on Contact page (#3153) commit dcd066f Author: Dan Zimmerman <[email protected]> Date: Tue Nov 1 16:29:34 2022 -0400 Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143) * Note milliseconds on API Concepts page * Add units and types to About Logging page Co-authored-by: dan <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 375b6cf Author: definitelyuncertain <[email protected]> Date: Fri Oct 28 14:30:22 2022 -0500 Change to mention explicit requirement for folder names for .msg and .srv files (#3144) * Change to mention explicit requirement for folder names for msg and srv files From ros2/tutorials#29 * fix typo Co-authored-by: Tomoya Fujita <[email protected]> * fix rst formatting Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit da871ef Author: Sergei Sergienko <[email protected]> Date: Thu Oct 27 17:20:06 2022 +0300 fix link to Gazebo-ROS2 bridge + CLI examples (#3139) * fix link to Gazebo-ROS2 bridge + CLI examples Co-authored-by: Chris Lalancette <[email protected]> commit e19c9b5 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 16:31:21 2022 -0400 Update the language to match the source code. (#3135) Fallout from #2865 Signed-off-by: Chris Lalancette <[email protected]> commit a5910a1 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 08:38:36 2022 -0400 Shorten the Windows build-from-source path. (#3130) * Shorten the Windows build-from-source path. This is to keep the total length down below the 260 character limit imposed by Windows by default. Signed-off-by: Chris Lalancette <[email protected]> commit 8225686 Author: Chris Lalancette <[email protected]> Date: Mon Oct 24 08:30:37 2022 -0400 Fix up the variable name in the traveling in time (C++) tutorial. (#3115) This is just to match what is in the code in the upstream repository. Signed-off-by: Chris Lalancette <[email protected]> commit 87ab121 Author: Ian Colwell <[email protected]> Date: Fri Oct 21 11:07:30 2022 -0400 Update default WORKING_DIRECTORY for ament_add_gtest() (#3117) commit 87bf20a Author: chianfern <[email protected]> Date: Tue Oct 18 21:36:57 2022 +0800 Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865) * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial. Signed-off-by: Tan Chian Fern <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 77646ce Author: George Stavrinos <[email protected]> Date: Tue Oct 18 15:29:37 2022 +0300 Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107) commit 1d24955 Author: Chris Lalancette <[email protected]> Date: Mon Oct 17 14:06:52 2022 -0400 Monitor parameter changes: Add note to save callback handle (#3102) Signed-off-by: Chris Lalancette <[email protected]> commit 8910a80 Author: David V. Lu!! <[email protected]> Date: Fri Oct 14 09:56:14 2022 -0400 Some testing basics (#3084) * Some testing basics Signed-off-by: David V. Lu <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 8771452 Author: Tomoya Fujita <[email protected]> Date: Fri Oct 14 05:34:20 2022 -0700 Sony's task for Iron Release. (#3089) * Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 2ea9e7d Author: Yannick Goumaz <[email protected]> Date: Fri Oct 14 14:23:13 2022 +0200 Update Setting-up a Robot Simulation (Webots) tutorial (#3090) * Update intro to WSL * Update world with declarations * Add supervisor node and environment var * Update tutorial with explanations Co-authored-by: ad-daniel <[email protected]> commit 0390a50 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Date: Thu Oct 13 13:42:30 2022 -0400 fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088) * fix command to install humble on Ubuntu 20.04 Co-authored-by: paolo.dimasi <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 5626af9) Co-authored-by: Paolo Dimasi <[email protected]> * Update Webots.rst * Update Webots.rst * Remove trailing white spaces * Update to VM and no supervisor * Remove wrong text * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> --------- Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Olivier Michel <[email protected]> (cherry picked from commit 588b10a)
mergify bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
…3317) * Update intro to WSL * Revert "Update intro to WSL" This reverts commit 52a52d0. * Update intro to wsl * Remove windows tabs * Add windows WSL tab for extern controller code * Clean tutorial * Update world with declarations * Add supervisor node and environment var * Add ros2supervisorlauncher node creation in launch files * add env variable for linux * Update tutorial with explanations * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: ad-daniel <[email protected]> * include correct file for supervisor part * Add WEBOTS_CONTROLLER_URL wsl infos * cleanup * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Remove confusing sentence * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Squashed commit of the following: commit 72effa7 Author: Luke Schmitt <[email protected]> Date: Tue Nov 1 17:26:25 2022 -0500 Fix list formatting on Contact page (#3153) commit dcd066f Author: Dan Zimmerman <[email protected]> Date: Tue Nov 1 16:29:34 2022 -0400 Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143) * Note milliseconds on API Concepts page * Add units and types to About Logging page Co-authored-by: dan <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 375b6cf Author: definitelyuncertain <[email protected]> Date: Fri Oct 28 14:30:22 2022 -0500 Change to mention explicit requirement for folder names for .msg and .srv files (#3144) * Change to mention explicit requirement for folder names for msg and srv files From ros2/tutorials#29 * fix typo Co-authored-by: Tomoya Fujita <[email protected]> * fix rst formatting Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit da871ef Author: Sergei Sergienko <[email protected]> Date: Thu Oct 27 17:20:06 2022 +0300 fix link to Gazebo-ROS2 bridge + CLI examples (#3139) * fix link to Gazebo-ROS2 bridge + CLI examples Co-authored-by: Chris Lalancette <[email protected]> commit e19c9b5 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 16:31:21 2022 -0400 Update the language to match the source code. (#3135) Fallout from #2865 Signed-off-by: Chris Lalancette <[email protected]> commit a5910a1 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 08:38:36 2022 -0400 Shorten the Windows build-from-source path. (#3130) * Shorten the Windows build-from-source path. This is to keep the total length down below the 260 character limit imposed by Windows by default. Signed-off-by: Chris Lalancette <[email protected]> commit 8225686 Author: Chris Lalancette <[email protected]> Date: Mon Oct 24 08:30:37 2022 -0400 Fix up the variable name in the traveling in time (C++) tutorial. (#3115) This is just to match what is in the code in the upstream repository. Signed-off-by: Chris Lalancette <[email protected]> commit 87ab121 Author: Ian Colwell <[email protected]> Date: Fri Oct 21 11:07:30 2022 -0400 Update default WORKING_DIRECTORY for ament_add_gtest() (#3117) commit 87bf20a Author: chianfern <[email protected]> Date: Tue Oct 18 21:36:57 2022 +0800 Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865) * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial. Signed-off-by: Tan Chian Fern <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 77646ce Author: George Stavrinos <[email protected]> Date: Tue Oct 18 15:29:37 2022 +0300 Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107) commit 1d24955 Author: Chris Lalancette <[email protected]> Date: Mon Oct 17 14:06:52 2022 -0400 Monitor parameter changes: Add note to save callback handle (#3102) Signed-off-by: Chris Lalancette <[email protected]> commit 8910a80 Author: David V. Lu!! <[email protected]> Date: Fri Oct 14 09:56:14 2022 -0400 Some testing basics (#3084) * Some testing basics Signed-off-by: David V. Lu <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 8771452 Author: Tomoya Fujita <[email protected]> Date: Fri Oct 14 05:34:20 2022 -0700 Sony's task for Iron Release. (#3089) * Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 2ea9e7d Author: Yannick Goumaz <[email protected]> Date: Fri Oct 14 14:23:13 2022 +0200 Update Setting-up a Robot Simulation (Webots) tutorial (#3090) * Update intro to WSL * Update world with declarations * Add supervisor node and environment var * Update tutorial with explanations Co-authored-by: ad-daniel <[email protected]> commit 0390a50 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Date: Thu Oct 13 13:42:30 2022 -0400 fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088) * fix command to install humble on Ubuntu 20.04 Co-authored-by: paolo.dimasi <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 5626af9) Co-authored-by: Paolo Dimasi <[email protected]> * Update Webots.rst * Update intro to wsl * Remove windows tabs * Add windows WSL tab for extern controller code * Clean tutorial * Add ros2supervisorlauncher node creation in launch files * Update intro to WSL * Update tutorial with explanations * include correct file for supervisor part * Add WEBOTS_CONTROLLER_URL wsl infos * cleanup * Remove confusing sentence * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Squashed commit of the following: commit 72effa7 Author: Luke Schmitt <[email protected]> Date: Tue Nov 1 17:26:25 2022 -0500 Fix list formatting on Contact page (#3153) commit dcd066f Author: Dan Zimmerman <[email protected]> Date: Tue Nov 1 16:29:34 2022 -0400 Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143) * Note milliseconds on API Concepts page * Add units and types to About Logging page Co-authored-by: dan <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 375b6cf Author: definitelyuncertain <[email protected]> Date: Fri Oct 28 14:30:22 2022 -0500 Change to mention explicit requirement for folder names for .msg and .srv files (#3144) * Change to mention explicit requirement for folder names for msg and srv files From ros2/tutorials#29 * fix typo Co-authored-by: Tomoya Fujita <[email protected]> * fix rst formatting Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit da871ef Author: Sergei Sergienko <[email protected]> Date: Thu Oct 27 17:20:06 2022 +0300 fix link to Gazebo-ROS2 bridge + CLI examples (#3139) * fix link to Gazebo-ROS2 bridge + CLI examples Co-authored-by: Chris Lalancette <[email protected]> commit e19c9b5 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 16:31:21 2022 -0400 Update the language to match the source code. (#3135) Fallout from #2865 Signed-off-by: Chris Lalancette <[email protected]> commit a5910a1 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 08:38:36 2022 -0400 Shorten the Windows build-from-source path. (#3130) * Shorten the Windows build-from-source path. This is to keep the total length down below the 260 character limit imposed by Windows by default. Signed-off-by: Chris Lalancette <[email protected]> commit 8225686 Author: Chris Lalancette <[email protected]> Date: Mon Oct 24 08:30:37 2022 -0400 Fix up the variable name in the traveling in time (C++) tutorial. (#3115) This is just to match what is in the code in the upstream repository. Signed-off-by: Chris Lalancette <[email protected]> commit 87ab121 Author: Ian Colwell <[email protected]> Date: Fri Oct 21 11:07:30 2022 -0400 Update default WORKING_DIRECTORY for ament_add_gtest() (#3117) commit 87bf20a Author: chianfern <[email protected]> Date: Tue Oct 18 21:36:57 2022 +0800 Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865) * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial. Signed-off-by: Tan Chian Fern <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 77646ce Author: George Stavrinos <[email protected]> Date: Tue Oct 18 15:29:37 2022 +0300 Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107) commit 1d24955 Author: Chris Lalancette <[email protected]> Date: Mon Oct 17 14:06:52 2022 -0400 Monitor parameter changes: Add note to save callback handle (#3102) Signed-off-by: Chris Lalancette <[email protected]> commit 8910a80 Author: David V. Lu!! <[email protected]> Date: Fri Oct 14 09:56:14 2022 -0400 Some testing basics (#3084) * Some testing basics Signed-off-by: David V. Lu <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 8771452 Author: Tomoya Fujita <[email protected]> Date: Fri Oct 14 05:34:20 2022 -0700 Sony's task for Iron Release. (#3089) * Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 2ea9e7d Author: Yannick Goumaz <[email protected]> Date: Fri Oct 14 14:23:13 2022 +0200 Update Setting-up a Robot Simulation (Webots) tutorial (#3090) * Update intro to WSL * Update world with declarations * Add supervisor node and environment var * Update tutorial with explanations Co-authored-by: ad-daniel <[email protected]> commit 0390a50 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Date: Thu Oct 13 13:42:30 2022 -0400 fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088) * fix command to install humble on Ubuntu 20.04 Co-authored-by: paolo.dimasi <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 5626af9) Co-authored-by: Paolo Dimasi <[email protected]> * Update Webots.rst * Update Webots.rst * Remove trailing white spaces * Update to VM and no supervisor * Remove wrong text * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> --------- Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Olivier Michel <[email protected]> (cherry picked from commit 588b10a)
audrow
pushed a commit
that referenced
this pull request
Feb 13, 2023
…3317) (#3332) * Update intro to WSL * Revert "Update intro to WSL" This reverts commit 52a52d0. * Update intro to wsl * Remove windows tabs * Add windows WSL tab for extern controller code * Clean tutorial * Update world with declarations * Add supervisor node and environment var * Add ros2supervisorlauncher node creation in launch files * add env variable for linux * Update tutorial with explanations * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: ad-daniel <[email protected]> * include correct file for supervisor part * Add WEBOTS_CONTROLLER_URL wsl infos * cleanup * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Remove confusing sentence * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Squashed commit of the following: commit 72effa7 Author: Luke Schmitt <[email protected]> Date: Tue Nov 1 17:26:25 2022 -0500 Fix list formatting on Contact page (#3153) commit dcd066f Author: Dan Zimmerman <[email protected]> Date: Tue Nov 1 16:29:34 2022 -0400 Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143) * Note milliseconds on API Concepts page * Add units and types to About Logging page Co-authored-by: dan <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 375b6cf Author: definitelyuncertain <[email protected]> Date: Fri Oct 28 14:30:22 2022 -0500 Change to mention explicit requirement for folder names for .msg and .srv files (#3144) * Change to mention explicit requirement for folder names for msg and srv files From ros2/tutorials#29 * fix typo Co-authored-by: Tomoya Fujita <[email protected]> * fix rst formatting Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit da871ef Author: Sergei Sergienko <[email protected]> Date: Thu Oct 27 17:20:06 2022 +0300 fix link to Gazebo-ROS2 bridge + CLI examples (#3139) * fix link to Gazebo-ROS2 bridge + CLI examples Co-authored-by: Chris Lalancette <[email protected]> commit e19c9b5 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 16:31:21 2022 -0400 Update the language to match the source code. (#3135) Fallout from #2865 Signed-off-by: Chris Lalancette <[email protected]> commit a5910a1 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 08:38:36 2022 -0400 Shorten the Windows build-from-source path. (#3130) * Shorten the Windows build-from-source path. This is to keep the total length down below the 260 character limit imposed by Windows by default. Signed-off-by: Chris Lalancette <[email protected]> commit 8225686 Author: Chris Lalancette <[email protected]> Date: Mon Oct 24 08:30:37 2022 -0400 Fix up the variable name in the traveling in time (C++) tutorial. (#3115) This is just to match what is in the code in the upstream repository. Signed-off-by: Chris Lalancette <[email protected]> commit 87ab121 Author: Ian Colwell <[email protected]> Date: Fri Oct 21 11:07:30 2022 -0400 Update default WORKING_DIRECTORY for ament_add_gtest() (#3117) commit 87bf20a Author: chianfern <[email protected]> Date: Tue Oct 18 21:36:57 2022 +0800 Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865) * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial. Signed-off-by: Tan Chian Fern <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 77646ce Author: George Stavrinos <[email protected]> Date: Tue Oct 18 15:29:37 2022 +0300 Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107) commit 1d24955 Author: Chris Lalancette <[email protected]> Date: Mon Oct 17 14:06:52 2022 -0400 Monitor parameter changes: Add note to save callback handle (#3102) Signed-off-by: Chris Lalancette <[email protected]> commit 8910a80 Author: David V. Lu!! <[email protected]> Date: Fri Oct 14 09:56:14 2022 -0400 Some testing basics (#3084) * Some testing basics Signed-off-by: David V. Lu <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 8771452 Author: Tomoya Fujita <[email protected]> Date: Fri Oct 14 05:34:20 2022 -0700 Sony's task for Iron Release. (#3089) * Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 2ea9e7d Author: Yannick Goumaz <[email protected]> Date: Fri Oct 14 14:23:13 2022 +0200 Update Setting-up a Robot Simulation (Webots) tutorial (#3090) * Update intro to WSL * Update world with declarations * Add supervisor node and environment var * Update tutorial with explanations Co-authored-by: ad-daniel <[email protected]> commit 0390a50 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Date: Thu Oct 13 13:42:30 2022 -0400 fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088) * fix command to install humble on Ubuntu 20.04 Co-authored-by: paolo.dimasi <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 5626af9) Co-authored-by: Paolo Dimasi <[email protected]> * Update Webots.rst * Update intro to wsl * Remove windows tabs * Add windows WSL tab for extern controller code * Clean tutorial * Add ros2supervisorlauncher node creation in launch files * Update intro to WSL * Update tutorial with explanations * include correct file for supervisor part * Add WEBOTS_CONTROLLER_URL wsl infos * cleanup * Remove confusing sentence * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Squashed commit of the following: commit 72effa7 Author: Luke Schmitt <[email protected]> Date: Tue Nov 1 17:26:25 2022 -0500 Fix list formatting on Contact page (#3153) commit dcd066f Author: Dan Zimmerman <[email protected]> Date: Tue Nov 1 16:29:34 2022 -0400 Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143) * Note milliseconds on API Concepts page * Add units and types to About Logging page Co-authored-by: dan <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 375b6cf Author: definitelyuncertain <[email protected]> Date: Fri Oct 28 14:30:22 2022 -0500 Change to mention explicit requirement for folder names for .msg and .srv files (#3144) * Change to mention explicit requirement for folder names for msg and srv files From ros2/tutorials#29 * fix typo Co-authored-by: Tomoya Fujita <[email protected]> * fix rst formatting Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit da871ef Author: Sergei Sergienko <[email protected]> Date: Thu Oct 27 17:20:06 2022 +0300 fix link to Gazebo-ROS2 bridge + CLI examples (#3139) * fix link to Gazebo-ROS2 bridge + CLI examples Co-authored-by: Chris Lalancette <[email protected]> commit e19c9b5 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 16:31:21 2022 -0400 Update the language to match the source code. (#3135) Fallout from #2865 Signed-off-by: Chris Lalancette <[email protected]> commit a5910a1 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 08:38:36 2022 -0400 Shorten the Windows build-from-source path. (#3130) * Shorten the Windows build-from-source path. This is to keep the total length down below the 260 character limit imposed by Windows by default. Signed-off-by: Chris Lalancette <[email protected]> commit 8225686 Author: Chris Lalancette <[email protected]> Date: Mon Oct 24 08:30:37 2022 -0400 Fix up the variable name in the traveling in time (C++) tutorial. (#3115) This is just to match what is in the code in the upstream repository. Signed-off-by: Chris Lalancette <[email protected]> commit 87ab121 Author: Ian Colwell <[email protected]> Date: Fri Oct 21 11:07:30 2022 -0400 Update default WORKING_DIRECTORY for ament_add_gtest() (#3117) commit 87bf20a Author: chianfern <[email protected]> Date: Tue Oct 18 21:36:57 2022 +0800 Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865) * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial. Signed-off-by: Tan Chian Fern <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 77646ce Author: George Stavrinos <[email protected]> Date: Tue Oct 18 15:29:37 2022 +0300 Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107) commit 1d24955 Author: Chris Lalancette <[email protected]> Date: Mon Oct 17 14:06:52 2022 -0400 Monitor parameter changes: Add note to save callback handle (#3102) Signed-off-by: Chris Lalancette <[email protected]> commit 8910a80 Author: David V. Lu!! <[email protected]> Date: Fri Oct 14 09:56:14 2022 -0400 Some testing basics (#3084) * Some testing basics Signed-off-by: David V. Lu <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 8771452 Author: Tomoya Fujita <[email protected]> Date: Fri Oct 14 05:34:20 2022 -0700 Sony's task for Iron Release. (#3089) * Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 2ea9e7d Author: Yannick Goumaz <[email protected]> Date: Fri Oct 14 14:23:13 2022 +0200 Update Setting-up a Robot Simulation (Webots) tutorial (#3090) * Update intro to WSL * Update world with declarations * Add supervisor node and environment var * Update tutorial with explanations Co-authored-by: ad-daniel <[email protected]> commit 0390a50 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Date: Thu Oct 13 13:42:30 2022 -0400 fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088) * fix command to install humble on Ubuntu 20.04 Co-authored-by: paolo.dimasi <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 5626af9) Co-authored-by: Paolo Dimasi <[email protected]> * Update Webots.rst * Update Webots.rst * Remove trailing white spaces * Update to VM and no supervisor * Remove wrong text * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> --------- Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Olivier Michel <[email protected]> (cherry picked from commit 588b10a) Co-authored-by: Yannick Goumaz <[email protected]>
audrow
pushed a commit
that referenced
this pull request
Feb 13, 2023
…3317) (#3331) * Update intro to WSL * Revert "Update intro to WSL" This reverts commit 52a52d0. * Update intro to wsl * Remove windows tabs * Add windows WSL tab for extern controller code * Clean tutorial * Update world with declarations * Add supervisor node and environment var * Add ros2supervisorlauncher node creation in launch files * add env variable for linux * Update tutorial with explanations * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: ad-daniel <[email protected]> * include correct file for supervisor part * Add WEBOTS_CONTROLLER_URL wsl infos * cleanup * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Remove confusing sentence * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Squashed commit of the following: commit 72effa7 Author: Luke Schmitt <[email protected]> Date: Tue Nov 1 17:26:25 2022 -0500 Fix list formatting on Contact page (#3153) commit dcd066f Author: Dan Zimmerman <[email protected]> Date: Tue Nov 1 16:29:34 2022 -0400 Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143) * Note milliseconds on API Concepts page * Add units and types to About Logging page Co-authored-by: dan <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 375b6cf Author: definitelyuncertain <[email protected]> Date: Fri Oct 28 14:30:22 2022 -0500 Change to mention explicit requirement for folder names for .msg and .srv files (#3144) * Change to mention explicit requirement for folder names for msg and srv files From ros2/tutorials#29 * fix typo Co-authored-by: Tomoya Fujita <[email protected]> * fix rst formatting Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit da871ef Author: Sergei Sergienko <[email protected]> Date: Thu Oct 27 17:20:06 2022 +0300 fix link to Gazebo-ROS2 bridge + CLI examples (#3139) * fix link to Gazebo-ROS2 bridge + CLI examples Co-authored-by: Chris Lalancette <[email protected]> commit e19c9b5 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 16:31:21 2022 -0400 Update the language to match the source code. (#3135) Fallout from #2865 Signed-off-by: Chris Lalancette <[email protected]> commit a5910a1 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 08:38:36 2022 -0400 Shorten the Windows build-from-source path. (#3130) * Shorten the Windows build-from-source path. This is to keep the total length down below the 260 character limit imposed by Windows by default. Signed-off-by: Chris Lalancette <[email protected]> commit 8225686 Author: Chris Lalancette <[email protected]> Date: Mon Oct 24 08:30:37 2022 -0400 Fix up the variable name in the traveling in time (C++) tutorial. (#3115) This is just to match what is in the code in the upstream repository. Signed-off-by: Chris Lalancette <[email protected]> commit 87ab121 Author: Ian Colwell <[email protected]> Date: Fri Oct 21 11:07:30 2022 -0400 Update default WORKING_DIRECTORY for ament_add_gtest() (#3117) commit 87bf20a Author: chianfern <[email protected]> Date: Tue Oct 18 21:36:57 2022 +0800 Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865) * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial. Signed-off-by: Tan Chian Fern <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 77646ce Author: George Stavrinos <[email protected]> Date: Tue Oct 18 15:29:37 2022 +0300 Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107) commit 1d24955 Author: Chris Lalancette <[email protected]> Date: Mon Oct 17 14:06:52 2022 -0400 Monitor parameter changes: Add note to save callback handle (#3102) Signed-off-by: Chris Lalancette <[email protected]> commit 8910a80 Author: David V. Lu!! <[email protected]> Date: Fri Oct 14 09:56:14 2022 -0400 Some testing basics (#3084) * Some testing basics Signed-off-by: David V. Lu <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 8771452 Author: Tomoya Fujita <[email protected]> Date: Fri Oct 14 05:34:20 2022 -0700 Sony's task for Iron Release. (#3089) * Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 2ea9e7d Author: Yannick Goumaz <[email protected]> Date: Fri Oct 14 14:23:13 2022 +0200 Update Setting-up a Robot Simulation (Webots) tutorial (#3090) * Update intro to WSL * Update world with declarations * Add supervisor node and environment var * Update tutorial with explanations Co-authored-by: ad-daniel <[email protected]> commit 0390a50 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Date: Thu Oct 13 13:42:30 2022 -0400 fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088) * fix command to install humble on Ubuntu 20.04 Co-authored-by: paolo.dimasi <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 5626af9) Co-authored-by: Paolo Dimasi <[email protected]> * Update Webots.rst * Update intro to wsl * Remove windows tabs * Add windows WSL tab for extern controller code * Clean tutorial * Add ros2supervisorlauncher node creation in launch files * Update intro to WSL * Update tutorial with explanations * include correct file for supervisor part * Add WEBOTS_CONTROLLER_URL wsl infos * cleanup * Remove confusing sentence * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> * Squashed commit of the following: commit 72effa7 Author: Luke Schmitt <[email protected]> Date: Tue Nov 1 17:26:25 2022 -0500 Fix list formatting on Contact page (#3153) commit dcd066f Author: Dan Zimmerman <[email protected]> Date: Tue Nov 1 16:29:34 2022 -0400 Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143) * Note milliseconds on API Concepts page * Add units and types to About Logging page Co-authored-by: dan <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 375b6cf Author: definitelyuncertain <[email protected]> Date: Fri Oct 28 14:30:22 2022 -0500 Change to mention explicit requirement for folder names for .msg and .srv files (#3144) * Change to mention explicit requirement for folder names for msg and srv files From ros2/tutorials#29 * fix typo Co-authored-by: Tomoya Fujita <[email protected]> * fix rst formatting Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit da871ef Author: Sergei Sergienko <[email protected]> Date: Thu Oct 27 17:20:06 2022 +0300 fix link to Gazebo-ROS2 bridge + CLI examples (#3139) * fix link to Gazebo-ROS2 bridge + CLI examples Co-authored-by: Chris Lalancette <[email protected]> commit e19c9b5 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 16:31:21 2022 -0400 Update the language to match the source code. (#3135) Fallout from #2865 Signed-off-by: Chris Lalancette <[email protected]> commit a5910a1 Author: Chris Lalancette <[email protected]> Date: Wed Oct 26 08:38:36 2022 -0400 Shorten the Windows build-from-source path. (#3130) * Shorten the Windows build-from-source path. This is to keep the total length down below the 260 character limit imposed by Windows by default. Signed-off-by: Chris Lalancette <[email protected]> commit 8225686 Author: Chris Lalancette <[email protected]> Date: Mon Oct 24 08:30:37 2022 -0400 Fix up the variable name in the traveling in time (C++) tutorial. (#3115) This is just to match what is in the code in the upstream repository. Signed-off-by: Chris Lalancette <[email protected]> commit 87ab121 Author: Ian Colwell <[email protected]> Date: Fri Oct 21 11:07:30 2022 -0400 Update default WORKING_DIRECTORY for ament_add_gtest() (#3117) commit 87bf20a Author: chianfern <[email protected]> Date: Tue Oct 18 21:36:57 2022 +0800 Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865) * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial. Signed-off-by: Tan Chian Fern <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 77646ce Author: George Stavrinos <[email protected]> Date: Tue Oct 18 15:29:37 2022 +0300 Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107) commit 1d24955 Author: Chris Lalancette <[email protected]> Date: Mon Oct 17 14:06:52 2022 -0400 Monitor parameter changes: Add note to save callback handle (#3102) Signed-off-by: Chris Lalancette <[email protected]> commit 8910a80 Author: David V. Lu!! <[email protected]> Date: Fri Oct 14 09:56:14 2022 -0400 Some testing basics (#3084) * Some testing basics Signed-off-by: David V. Lu <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> commit 8771452 Author: Tomoya Fujita <[email protected]> Date: Fri Oct 14 05:34:20 2022 -0700 Sony's task for Iron Release. (#3089) * Sony's task for Iron Release. Signed-off-by: Tomoya.Fujita <[email protected]> * Rearrange and add in links. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> commit 2ea9e7d Author: Yannick Goumaz <[email protected]> Date: Fri Oct 14 14:23:13 2022 +0200 Update Setting-up a Robot Simulation (Webots) tutorial (#3090) * Update intro to WSL * Update world with declarations * Add supervisor node and environment var * Update tutorial with explanations Co-authored-by: ad-daniel <[email protected]> commit 0390a50 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Date: Thu Oct 13 13:42:30 2022 -0400 fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088) * fix command to install humble on Ubuntu 20.04 Co-authored-by: paolo.dimasi <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 5626af9) Co-authored-by: Paolo Dimasi <[email protected]> * Update Webots.rst * Update Webots.rst * Remove trailing white spaces * Update to VM and no supervisor * Remove wrong text * Update source/Tutorials/Advanced/Simulators/Webots.rst Co-authored-by: Olivier Michel <[email protected]> --------- Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Olivier Michel <[email protected]> (cherry picked from commit 588b10a) Co-authored-by: Yannick Goumaz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@clalancette
CC: @wjwwood
Signed-off-by: Tomoya.Fujita [email protected]