move qos_profile_rosout_default from rcl. #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya
requested review from
methylDragon,
ivanpauno and
wjwwood
as code owners
fujitatomoya
commented
Nov 6, 2024
| @@ -87,6 +87,19 @@ static const rmw_qos_profile_t rmw_qos_profile_parameter_events = | |||
| false | |||
| }; | |||
|
|
|||
| static const rmw_qos_profile_t rmw_qos_profile_rosout_default = | |||
There was a problem hiding this comment.
qos profile for rosout publisher is defined in rcl. it should be moved here with other profiles. see more details for ros2/rcl#1195
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related and need to be merged before ros2/rclpy#1376