Decoupled the additional feature from rcl to rcutils, reflecting on t… #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he pointing out below. ros2/rclcpp#2205 (comment) Signed-off-by: Shoji Morita <[email protected]>
smorita-esol
requested review from
ahcorde,
clalancette and
wjwwood
as code owners
ahcorde
requested changes
Jun 20, 2023
| /** | ||
| * \brief Initialize list of thread attributes with a capacity. | ||
| * \param[out] thread_attrs list of thread attributes to be initialized | ||
| * \param[in] allocator memory allocator to be used |
There was a problem hiding this comment.
Suggested change
| * \param[in] allocator memory allocator to be used | |
| * \param[in] allocator memory allocator to be used | |
| * \param[in] capacity ... |
There was a problem hiding this comment.
Thanks for your suggestion.
I've addressed it in ec49b25.
Reflecting on the suggestion for the comments of thread_attr.h. Signed-off-by: Shoji Morita <[email protected]>
smorita-esol
force-pushed
the
origin/sched_param_control_for_osrf
branch
from
c73ab59
to
ec49b25
Compare
Signed-off-by: Shoji Morita <[email protected]>
…e update of REP-2017 below. ros-infrastructure/rep#385 Signed-off-by: Shoji Morita <[email protected]>
…he thread below. ros-infrastructure/rep#385 (comment) Signed-off-by: Shoji Morita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to decouple the new feature included in the PR of rcl below into rcutils.
ros2/rcl#1075
REFS:
ros2/rclcpp#2205 (comment)