Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split test_executors.cpp even further. (backport #2572) #2619

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 4, 2024

That's because it is too large for Windows Debug to compile, so split into smaller bits.

Even with this split, the file is too big; that's likely because we are using TYPED_TEST here, which generates multiple symbols per test case. To deal with this, without further breaking up the file, also add in the /bigobj flag when compiling on Windows Debug.

@Crola1702 FYI; this should fix osrf/buildfarm-tools#63 (comment)


This is an automatic backport of pull request #2572 done by Mergify.

@mergify mergify bot requested a review from ivanpauno as a code owner September 4, 2024 14:23
@mergify mergify bot added the conflicts label Sep 4, 2024
Copy link
Contributor Author

mergify bot commented Sep 4, 2024

Cherry-pick of c743c17 has failed:

On branch mergify/bp/jazzy/pr-2572
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit c743c173.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rclcpp/test/rclcpp/CMakeLists.txt
	new file:   rclcpp/test/rclcpp/executors/test_executors_busy_waiting.cpp
	new file:   rclcpp/test/rclcpp/executors/test_waitable.cpp
	new file:   rclcpp/test/rclcpp/executors/test_waitable.hpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp/test/rclcpp/executors/test_executors.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

That's because it is too large for Windows Debug to compile,
so split into smaller bits.

Even with this split, the file is too big; that's likely
because we are using TYPED_TEST here, which generates multiple
symbols per test case.  To deal with this, without further
breaking up the file, also add in the /bigobj flag when
compiling on Windows Debug.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit c743c17)
@clalancette
Copy link
Contributor

clalancette commented Sep 4, 2024

Pulls: #2619
Gist: https://gist.githubusercontent.com/clalancette/00dc952ea072e7042c7a24011851fdcb/raw/4ab92a0fdff5d2c6163a6b5a1b246409a65a5557/ros2.repos
BUILD args: --packages-up-to rclcpp
TEST args: --packages-select rclcpp
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14506

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status
  • Windows Debug Build Status

@clalancette clalancette merged commit 830a1f0 into jazzy Sep 6, 2024
3 checks passed
@clalancette clalancette deleted the mergify/bp/jazzy/pr-2572 branch September 6, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants