add impl pointer for ExecutorOptions (backport #2523) #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* add impl pointer for ExecutorOptions Signed-off-by: William Woodall <[email protected]> (cherry picked from commit 343b29b)
|
CI:
|
ahcorde
approved these changes
May 9, 2024
wjwwood
approved these changes
May 9, 2024
|
Here's a rebuild on Windows, since it failed some tests that I'm not sure it should have:
|
marcoag
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #2505 (comment), we need this to potentially add more functionality to Jazzy post release, as well it gives us more flexibility to fix bugs in the future.
We already have this for the
Executor, so this class is the only one that needs adjustment:rclcpp/rclcpp/include/rclcpp/executor.hpp
Line 597 in f7185dc
This is an automatic backport of pull request #2523 done by Mergify.