node logger_name should be assigned after rmw_create_node.

[fujitatomoya]

address #983

Signed-off-by: Tomoya Fujita [email protected]

[clalancette]

While this addresses the immediate concern, I think this bug report points out a deeper problem; rcl_node_init is far too complicated as-is. I think the right thing to do here is to refactor this function completely so that it calls out to functions to do most of the work for it, which will make it much easier to follow. Also, a lot of the work that is done in the fail section could be shared with rcl_node_fini.

@fujitatomoya I won't outright block on this, but I think this whole thing will be much easier to reason about and maintain if we do that refactoring. What do you think?

[fujitatomoya]

@clalancette agree, probably refactoring would be best. and we can fix the problem aligned with it.