Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content filtered topic for action feedback subscription #901

Open
wants to merge 20 commits into
base: rolling
Choose a base branch
from

Conversation

iuhilnehc-ynos
Copy link
Collaborator

@iuhilnehc-ynos iuhilnehc-ynos commented Mar 23, 2021

related to ros2/design#282

action feedback enhancement

@fujitatomoya
Copy link
Collaborator

@iuhilnehc-ynos

this includes #894, right? it should depend on #894, so that this PR can be dedicated to action feedback subscription?

Comment on lines +748 to +754
feedback_filter_update =
rcutils_format_string(allocator, "goal_id.uuid = &hex(%s)", uuid_str);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checking, i wasn't clear before but this hex is not in the spec for interoperability? Annex B - Syntax for Queries and Filters?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's not the official spec.

@iuhilnehc-ynos
Copy link
Collaborator Author

@iuhilnehc-ynos

this includes #894, right? it should depend on #894, so that this PR can be dedicated to action feedback subscription?

Yes, based on #894 not reviewed, I think we can combine the part1(Just CFT interfaces) and part2(CFT for parameter_event and action feedback topics). Do you think the #894 can be closed?

@fujitatomoya
Copy link
Collaborator

I think we can combine the part1(Just CFT interfaces) and part2(CFT for parameter_event and action feedback topics). Do you think the #894 can be closed?

yeah, i guess so 😄

Chen Lihui and others added 20 commits October 11, 2021 13:10
Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
nit
Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
@audrow audrow changed the base branch from master to rolling June 28, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants