From 750fc166e0d2fb1fec02bbec52a9cd2a894cb940 Mon Sep 17 00:00:00 2001 From: Tomoya Fujita Date: Mon, 8 Jan 2024 09:35:05 -0800 Subject: [PATCH] add unit tests for --log-file-name argument. (#1130) Signed-off-by: Tomoya Fujita --- rcl/test/rcl/test_arguments.cpp | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/rcl/test/rcl/test_arguments.cpp b/rcl/test/rcl/test_arguments.cpp index bb493743a..3d944f510 100644 --- a/rcl/test/rcl/test_arguments.cpp +++ b/rcl/test/rcl/test_arguments.cpp @@ -184,6 +184,12 @@ TEST_F(TestArgumentsFixture, check_known_vs_unknown_args) { EXPECT_FALSE(are_known_ros_args({"--ros-args", "--log", "foo"})); EXPECT_FALSE(are_known_ros_args({"--ros-args", "--loglevel", "foo"})); + // Setting log file name prefix + EXPECT_TRUE(are_known_ros_args({"--ros-args", "--log-file-name", "filename"})); + + EXPECT_FALSE(are_known_ros_args({"--ros-args", "--logfile-name", "filename"})); + EXPECT_FALSE(are_known_ros_args({"--ros-args", "--log-filename", "filename"})); + // Disabling logging EXPECT_TRUE(are_known_ros_args({"--ros-args", "--enable-rosout-logs"})); EXPECT_TRUE(are_known_ros_args({"--ros-args", "--disable-rosout-logs"})); @@ -220,7 +226,7 @@ TEST_F(TestArgumentsFixture, check_valid_vs_invalid_args) { { "--ros-args", "-p", "foo:=bar", "-r", "__node:=node_name", "--params-file", parameters_filepath.c_str(), "--log-level", "INFO", - "--log-config-file", "file.config" + "--log-config-file", "file.config", "--log-file-name", "filename" })); // ROS args unknown to rcl are not (necessarily) invalid @@ -283,6 +289,8 @@ TEST_F(TestArgumentsFixture, check_valid_vs_invalid_args) { EXPECT_FALSE(are_valid_ros_args({"--ros-args", "--log-level"})); EXPECT_FALSE(are_valid_ros_args({"--ros-args", "--log-level", "foo"})); + + EXPECT_FALSE(are_valid_ros_args({"--ros-args", "--log-file-name"})); } TEST_F(TestArgumentsFixture, test_no_args) {