Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge and rename teams (ffmpeg_image_transport_team, misc_utilities) -> ros_misc_utilties #490

Closed
berndpfrommer opened this issue Apr 13, 2024 · 2 comments · Fixed by #492

Comments

@berndpfrommer
Copy link

I originally requested a team by the the name ros_misc_utilities in issue #390. This was closed by PR #408, but "ffmpeg_image_transport_team" was used as opposed to "ros_misc_utilities" as requested.

Sure enough, this caused confusion later when adding more repositories to the team. First when I requested the apriltag_detector repo being added to the "ros_misc_utilities" team (issue #440 closed by PR #446): a new team was created ("misc_utilities"), and the repo was associated with "misc_utilities".

But now when I requested to add the "ffmpeg_image_transport_tools" repo (issue #481) it was associated with "misc_utilities" in PR #488.

So we have two teams now: "ffmpeg_image_transport_team" and the "misc_utilities" team, neither of which matches the original requested "ros_misc_utilities" (which I chose to be the name of the github organization).

Can we merge these two teams into one (called "ros_misc_utilities")? If you dislike the "ros_" prefix, how about merging "ffmpeg_image_transport_team" into the "misc_utilities" team?

Thanks!

@nuclearsandwich
Copy link
Collaborator

Thanks for opening the issue.

The team here does our best to maintain a "rationale" structure for this large organization but this is very much in the eye of the beholder.

With respect to ros_misc_utilities vs misc_utilities, the convention that we've established is that for upstream organizations with a ros[-_] prefix where the project/package name is not ros_foobar, we'll drop the leading ros[-_] as otherwise we'll end up with 300 files named ros_whatever.tf. Which is how we arrived at the misc_utilites name for the release team and terraform file.

We can indeed consolidate the ffmpeg_image_transport team into misc_utiltiies. I've opened #492 to do just that. Please approve it if that meets your expectations.

While the changes are deploying, you may momentarily lose push access to the ffmpeg_image_transport repositories if that team is dropped before the misc_utilities team is updated but as you'll remain part of the ros2-gbp organization for the entire transition you should not need to accept any invites before access is re-granted under the other team.

@nuclearsandwich
Copy link
Collaborator

This change has been deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants