New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate accidental leaking of private API #34

Open

EricCousineau-TRI opened this issue Sep 6, 2018 · 1 comment

EricCousineau-TRI commented Sep 6, 2018

Relates #30, #14

It's hard to know what you can really change in the API since some of the internal implementation bits leaked out into the public namespace.

Ideally, it'd be nice to deprecate those private bits, and simplify the public interface, and do a bit more testing on it.

\cc @clalancette

eacousineau mentioned this issue

xml_reflection: First step to enable deprecation of public access #35

Open

Contributor

eacousineau commented Nov 20, 2018

Proposed steps:

Ensure that urdf.py (and sdf.py) do not transitively import symbols from xml_reflection, and try to handle class variabes.
Deprecate xml_reflection as a whole.
Once deprecation period has passed, delete deprecated members.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment