Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3-transitions #41662

Closed
wants to merge 0 commits into from
Closed

Add python3-transitions #41662

wants to merge 0 commits into from

Conversation

lennewbrook
Copy link
Contributor

Please add the following dependency to the rosdep database.

Package name:

python3-transitions

Package Upstream Source:

https://github.com/pytransitions/transitions

Purpose of using this:

python trasnsitrions is being used with ROS Humble and therefor needs to be available for Ubuntu :jammy and above

Distro packaging links:

@lennewbrook lennewbrook requested a review from a team as a code owner June 17, 2024 09:17
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Jun 17, 2024
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not going to work for multiple reasons:

  1. This could break anyone using the python-transitions key.
  2. This isn't in alphabetical order.
  3. This is missing other needed operating systems, like Debian.

Please put the old key (python-transitions) back as it was, then add a completely new key in the appropriate place. Also consider adding in other operating systems; you can get an idea of what is supported by looking at https://pkgs.org/search/?q=transitions

@github-actions github-actions bot removed the rosdep Issue/PR is for a rosdep key label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants