Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic reconfigure instead of standalone gui? #12

Open
lucasw opened this issue Aug 5, 2018 · 1 comment
Open

Use dynamic reconfigure instead of standalone gui? #12

lucasw opened this issue Aug 5, 2018 · 1 comment

Comments

@lucasw
Copy link
Contributor

lucasw commented Aug 5, 2018

The dynamic reconfigure option could use https://github.com/pal-robotics/ddynamic_reconfigure_python (ros-kinetic-ddynamic-reconfigure-python).

If the user wanted a standalone gui they could use https://github.com/lucasw/dynamic_reconfigure_tools/tree/master/rqt_dr_single (which I could split out into a standalone repo and actually release it, or maybe merge it with dynamic_reconfigure).

The use_gui flag could either be eliminated and the user would have to independently run a dynamic reconfigure client (which means I don't need to move sooner on releasing rqt_dr_single)- or an instance of rqt_dr_single could be launched programmatically?

Randomize and Center would become bool_t and would uncheck themselves after being checked.

Some of the gui configurability would be lost but this repo would be simplified, the qt dependency eliminated.

Another option would be to convert this to an rqt plugin and preserve the existing ui exactly, but have it be able to be embedded within a larger rqt panel or launched standalone. Like the dynamic reconfigure case would be simpler to get rid of the use_gui flag than preserve it.

lucasw added a commit to lucasw/joint_state_publisher that referenced this issue Aug 5, 2018
… (maybe should get it and then output a warning message if it exists?). TODO add tests ros#12
@lucasw
Copy link
Contributor Author

lucasw commented Aug 5, 2018

TODO If use_gui is false, don't launch the dr server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant