Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AnchorScan.msg #147

Open
wants to merge 1 commit into
base: jade-devel
Choose a base branch
from
Open

Conversation

elcingencturk
Copy link

This is a message to hold the fixed anchors' (UWB sensors) information at known coordinates and Time Difference of Arrival (TDOA) values. The indoor positioning systems developed using UWB signals include multiple sensors that transmit UWB signals in an environment. Calculations such as position, anchor selection etc. are made by using TDOA measurements from these sensors and coordinate information of the sensors. With the defined AnchorScan message, it allows the publish of this information from the sensors via any developed firmware.

This is a message to hold the fixed anchors' (UWB sensors) information at known coordinates and Time Difference of Arrival (TDOA) values. The indoor positioning systems developed using UWB signals include multiple sensors that transmit UWB signals in an environment. Calculations such as position, anchor selection etc. are made by using TDOA measurements from these sensors and coordinate information of the sensors.  With the defined AnchorScan message, it allows the publish of this information from the sensors via any developed firmware.
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing CI because the patch does not have the message definition. Likely it wasn't added before the commit was made.

However even prior to reviewing the message itself this seems moderately early in the development cycle to be merged into common messages. In general common_msgs is where we will put messages that are mature and well tested and maybe are a small iteration on existing messages or are a merge of a couple of different implementations that have traction but had differences that needed to be resolved.

To that end I'd suggest that this be not immediately released here in sensor_msgs but be released into something more like uwb_msgs or maybe something a little bit more generic for beacon based localization messages. That then can be developed against and potentially iterate more rapidly than we can do in common_msgs.

@tfoote tfoote mentioned this pull request Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants