Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated jekyll tag usage spamming console #307

Closed
tfoote opened this issue May 23, 2023 · 3 comments
Closed

deprecated jekyll tag usage spamming console #307

tfoote opened this issue May 23, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tfoote
Copy link
Member

tfoote commented May 23, 2023

The following output is spamming the console

There are about 160000 instances of it in each build constituting about 30% of our build output.

/home/jenkins-agent/.bundle/ruby/2.7.0/gems/jekyll-3.8.5/lib/jekyll/tags/include.rb:194: warning: Using the last argument as keyword parameters is deprecated

It's both a lot of console logging space and bandwidth as well as a risk of it breaking when the deprecation cycle finishes.

@tfoote tfoote added enhancement New feature or request help wanted Extra attention is needed labels May 23, 2023
@tfoote
Copy link
Member Author

tfoote commented May 23, 2023

This may be an issue in the jekyll version we're using we need to upgrade to 3.8.7 or higher

jekyll/jekyll#7947 (comment)

rkent added a commit to rkent/rosindex that referenced this issue Mar 6, 2024
@rkent
Copy link

rkent commented Mar 7, 2024

I posted a patch on my fork upgrading the Dockerfile to jammy, also updating Gemfile.lock Full run available (temporarily) at http://test3.rosdabbler.com

The main issue was newer jekyll no longer supports red carpet, so the md processor had to be changed to kramdown. That forced a minor fix concerning character encodings, but otherwise seems to work OK. "spamming the console" is greatly reduced, not only because of the jekyll upgrade, but also because I removed most of the --verbose options in the Makefile.

At this point I need to read through the issue history to see what historical issues have existed that might be affected by switching to kramdown. If there is a history here that anyone knows about, I would love to hear about it.

@tfoote
Copy link
Member Author

tfoote commented Sep 25, 2024

Fixed in #418

@tfoote tfoote closed this as completed Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants