Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tsdf_min_camera_movement #20

Open
mpowelson opened this issue Nov 12, 2019 · 2 comments
Open

Remove tsdf_min_camera_movement #20

mpowelson opened this issue Nov 12, 2019 · 2 comments

Comments

@mpowelson
Copy link
Contributor

This seems like a detail in the data capture not the reconstruction. In other words, I think this should be in yak_ros not yak itself. In fact, it is in both places now. I propose we remove it from yak (in kinfu.cpp) and let the data collection wrapper handle it (yak_ros).

@mpowelson
Copy link
Contributor Author

Along these same lines, update_via_sensor_motion also seems odd. Is there an application for it? I don't know if it currently works.

@schornakj
Copy link
Contributor

schornakj commented Nov 13, 2019

Agreed on removing the minimum motion threshold from kinfu.cpp. The TSDF server should merge whatever images are sent to it, and it should be the client's responsibility to manage when those images are merged.

I tried update_via_sensor_motion = true and it doesn't integrate relative to the correct frame. I think it can be safely removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants