Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add utility methods from_reader, from_slice, from_value similar to serde_json #255

Open
Tracked by #397
mainrs opened this issue Jul 13, 2020 · 3 comments
Open
Tracked by #397
Labels
enhancement good first issue Perfect for new contributors

Comments

@mainrs
Copy link
Contributor

mainrs commented Jul 13, 2020

It would be cool if these methods could be added to the public API of ron. If this is not already been tackled down I can open up a PR. Just assign the issue to be so I can keep track of it :)

Reference: https://docs.rs/serde_json/1.0.56/serde_json/#functions

@github-actions
Copy link

Issue has had no activity in the last 180 days and is going to be closed in 7 days if no further activity occurs

@github-actions github-actions bot added the stale label Nov 18, 2021
@kvark kvark reopened this Dec 3, 2021
@kvark
Copy link
Collaborator

kvark commented Dec 17, 2021

comment

@kvark kvark reopened this Dec 17, 2021
@github-actions github-actions bot removed the stale label Dec 18, 2021
@juntyr juntyr mentioned this issue Aug 14, 2022
7 tasks
@juntyr
Copy link
Member

juntyr commented Aug 15, 2022

The related PR #257 was closed. from_reader, from_str and from_slice from_bytes are already available in the de module. from_value is trivial to add (the functionality exists as value.into_rust()), but to_value requires more work. I think it'd make sense to tackle it together with #357, #217, #189, #140, #122 and #115 ... I guess I know now that I'll work on for 0.9 :)

@juntyr juntyr mentioned this issue Aug 15, 2022
17 tasks
@juntyr juntyr added the good first issue Perfect for new contributors label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Perfect for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants