-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many Tags are not marked as "Binary", even so they are - same to other types #12
Comments
This is, because ClassesBuilder:getTypeMap() treats the following types as string:
What about treating them as binary, because we for sure don't know what it's content is? |
I now found, that "double" is marked as "int", even so it's a "float" ... Please update the list according to the ReadMe! |
If you can push a PR, it would be awesome, otherwise I'll check this this week end |
I looked through the code ... Do you know something about the flag_Binary? Is this set for these items, or where will this be done? |
See #13 |
Where are these types actually used? Or - are they used at all? My problem is, that I want to serialize all mono and multiple data and save it to the database. Binary data is useless there, because it's not searchable. The binary-flag is triggered by the is_Binary flag in the XML given by Exiftool ... |
These type should help to cast values from RDF, but it is actually not yet implemented. |
Have you notices that TagInterface supports serialization via JMS Serializer ? |
Nope - haven't noticed that ... but that doesn't change the fact, that I still will have binary data in there. Btw: All serialization I need is handled by the database I use, so I shouldn't have to care about that. The database now is coupled directly to a search-engine, which I don't want to feed with useless data like f.e. some preview-images ;) |
I found out, that there are many tags in the system, that actually are binary, but not marked as one.
One example is: https://github.com/romainneutron/PHPExiftool/blame/master/lib/PHPExiftool/Driver/Tag/Canon/ThumbnailImage.php
Don't know if this is the responsibility of Exiftool or if it has do do something with the class-creator task ...
The text was updated successfully, but these errors were encountered: