Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC proxy #14

Merged
merged 10 commits into from
Oct 24, 2023
Merged

gRPC proxy #14

merged 10 commits into from
Oct 24, 2023

Conversation

tzdybal
Copy link
Member

@tzdybal tzdybal commented Oct 16, 2023

Overview

gRPC proxy allows developers to easily use DA interface over gRPC connection.
This PR also partially addresses #6 by refactoring test suite. Proxy client/server test shows how easy it is to reuse the test suite.

Resolves #5.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (6bd21b7) 0.00% compared to head (fd059e7) 84.04%.

Additional details and impacted files
@@            Coverage Diff            @@
##           main      #14       +/-   ##
=========================================
+ Coverage      0   84.04%   +84.04%     
=========================================
  Files         0        3        +3     
  Lines         0      163      +163     
=========================================
+ Hits          0      137      +137     
- Misses        0       18       +18     
- Partials      0        8        +8     
Files Coverage Δ
proxy/util.go 100.00% <100.00%> (ø)
proxy/server.go 76.47% <76.47%> (ø)
proxy/client.go 78.12% <78.12%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzdybal tzdybal enabled auto-merge (squash) October 16, 2023 11:09
tuxcanfly
tuxcanfly previously approved these changes Oct 20, 2023
Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

proto/da/da.proto Show resolved Hide resolved
proto/da/da.proto Outdated Show resolved Hide resolved
proxy/proxy_test.go Show resolved Hide resolved
test/test_suite.go Show resolved Hide resolved
Copy link
Member

@Manav-Aggarwal Manav-Aggarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nashqueue nashqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@tzdybal tzdybal merged commit 57bc360 into main Oct 24, 2023
12 checks passed
@tzdybal tzdybal deleted the tzdybal/grpc_proxy branch October 24, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create gRPC mapping of DA interface
4 participants