Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollbar Gem Docs out of date #1166

Open
matthewtusker opened this issue Sep 9, 2024 · 4 comments
Open

Rollbar Gem Docs out of date #1166

matthewtusker opened this issue Sep 9, 2024 · 4 comments
Assignees

Comments

@matthewtusker
Copy link

The Rollbar Gem configuration reference mentions that girl_friday is used when use_async is set to true. From the looks of the Gem girl_friday was replaced with sucker_punch (possibly 10+ years ago???). Can the configuration reference be updated to reflect this?

Copy link

linear bot commented Sep 9, 2024

@zdavis-rollbar zdavis-rollbar self-assigned this Sep 9, 2024
@zdavis-rollbar zdavis-rollbar added the Ruby label Sep 9, 2024 — with Linear
@waltjones
Copy link
Contributor

@matthewtusker , thank you for the report.

Rollbar-gem does still use girl_friday by default if it is present.
https://github.com/rollbar/rollbar-gem/blob/master/lib/rollbar/notifier.rb#L859-L863

The default when it isn't present is Thread, which is probably the best default going forward. Until this is changed in Rollbar-gem, the current doc is accurate.

@waltjones waltjones added the v4 label Sep 9, 2024
@zdavis-rollbar zdavis-rollbar closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2024
@waltjones
Copy link
Contributor

Reopening to change the default in next major version (v4).

@waltjones waltjones reopened this Sep 9, 2024
@matthewtusker
Copy link
Author

Ah, I hadn't found that in the codebase, I had just read through the gemspec and couldn't find a reference to it. I had assumed that it had been dropped since the last release was 11 years ago (January 2013).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants