Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope does not like false #1099

Open
blowfishpro opened this issue Jul 14, 2022 · 0 comments
Open

scope does not like false #1099

blowfishpro opened this issue Jul 14, 2022 · 0 comments
Labels

Comments

@blowfishpro
Copy link

Steps to reproduce:

Try to add some scope with a false value:

Rollbar.scoped(example: false) { Rollbar.error(Exception.new) }

Observed:

  • the example key does not appear on the exception
  • If you use any other truthy value (including true, numbers, or anthing else other than nil) it sends correctely

Desired:

  • false and true are treated the same way. Maybe nil is different?

Notes:

  • The behavior comes from this line - that condition is falsy with false or nil so nothing is done
  • Maybe the behavior of false and nil should be thought about here? To me false should be merged in like a normal value and nil indicates that we want to remove that value in the merged hash. But maybe others feel differently?
@waltjones waltjones added the bug label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants