Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.0 (latest) no longer works on Xcode 18 #136

Open
timothyrobb opened this issue Sep 17, 2024 · 6 comments
Open

v1.5.0 (latest) no longer works on Xcode 18 #136

timothyrobb opened this issue Sep 17, 2024 · 6 comments

Comments

@timothyrobb
Copy link

Using the latest released version of Xcode, v18, and using the latest version of rollbar_flutter, v1.5.0, we get compiler errors.

/<project_dir>/ios/Pods/RollbarCrash/RollbarNotifier/Sources/RollbarCrash/Monitors/RollbarCrashMonitor_CPPException.cpp:66:13: error: no type named 'terminate_handler' in namespace 'std'
    66 | static std::terminate_handler g_originalTerminateHandler;
      |        ~~~~~^
/<project_dir>/ios/Pods/RollbarCrash/RollbarNotifier/Sources/RollbarCrash/Monitors/RollbarCrashMonitor_CPPException.cpp:219:47: error: no member named 'set_terminate' in namespace 'std'
  219 |             g_originalTerminateHandler = std::set_terminate(CPPExceptionTerminate);
      |                                          ~~~~~^
/<project_dir>/ios/Pods/RollbarCrash/RollbarNotifier/Sources/RollbarCrash/Monitors/RollbarCrashMonitor_CPPException.cpp:223:18: error: no type named 'set_terminate' in namespace 'std'
  223 |             std::set_terminate(g_originalTerminateHandler);
      |             ~~~~~^
image

This makes the package and service entirely unusable for any project that uses the latest version of Xcode.

I know this package is barely maintained, if ever. But if this isn't patched shortly, you're going to find almost every user of this package disappearing over a few months and using another service entirely.

@timothyrobb
Copy link
Author

It looks like this has been fixed in RollbarNotifier 3.3.2
rollbar/rollbar-apple#348 (comment)

@kevinconcourse
Copy link

Hi, Any guide on how to fix this issue??

@diegoalex
Copy link

Same issue as @timothyrobb here. App stop building after update to XCode 18.

I've checked the code here and the version 1.5.0 still pointing to the old RollbarNotifier version

image

@sonjz
Copy link

sonjz commented Oct 28, 2024

It's been 14 months since the rollbar team updated pub.dev... that's a long time between platform versions:

  • Android 14 (Oct 4, 2023)
  • Android 15 (Oct 15, 2024)
  • iOS 17 (Sept 18, 2023)
  • iOS 18 (Sept 16, 2024)

I noticed some fixes on repo, and since this is technically still in beta, I'm targeting the repo directly in my pubspec.yml

dependencies:
...
  rollbar_flutter:
    git: 
      url: https://github.com/rollbar/rollbar-flutter.git
      ref: main
      path: rollbar_flutter/
...

Can we push this change, or anyone forked it yet?

@sonjz
Copy link

sonjz commented Oct 28, 2024

and ... shit.

from readme.

As of April 2024, Rollbar will not be actively updating this repository and plans to archive it. We encourage our community to fork this repo if you wish to continue its development. While Rollbar will no longer be engaging in active development, we remain committed to reviewing and merging pull requests, particularly those about security updates. If an actively maintained fork emerges, please let us know, and we will gladly link to it from our documentation.

sonjz pushed a commit to sonjz/rollbar-flutter that referenced this issue Oct 28, 2024
- updated to latest iOS RollbarNotifier based on comments here rollbar#136
- also ran into issue in AndroidManifest.xml where packagee name has moved to gradle namespace
@sonjz
Copy link

sonjz commented Nov 1, 2024

if anyone needs a fork, i updated code to handle RollbarNotifier and fixed the AndroidManifest.xml packageName/namespace issue for Android 15.

sonjz@265e9c9

add it to your pubspec.yaml with:

...
dependencies:
...
  rollbar_flutter:
    git: 
      url: https://github.com/sonjz/rollbar-flutter.git
      ref: main
      path: rollbar_flutter/
...

Hope this helps as a stopgap, but yup, project is dead... Crashalytics anyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants