-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable remote control on launch #503
Enable remote control on launch #503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I have a few suggestions on the general design of the launch.json settings.
And can you add a unit test or two ensuring that the "remoteControlMode": true
turns into "remoteControlMode": {...the stuff}
Thanks for the review - I think I got what you wanted out of this feature (I personally prefer to hit Command+K for the remote, this is why I haven't considered the different possible preferences) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Much closer! I think it would be nicer to eliminate the boolean
in the interface, so that it's just a shorthand in the config and we can more consistently interact with the activate/deactivate props downstream.
That's a good idea, I applied your suggestions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great. Thanks for this!
Closes #475