Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scoped logging in v4 #150

Open
TwitchBronBron opened this issue Mar 4, 2024 · 0 comments
Open

Support scoped logging in v4 #150

TwitchBronBron opened this issue Mar 4, 2024 · 0 comments
Assignees
Milestone

Comments

@TwitchBronBron
Copy link
Member

TwitchBronBron commented Mar 4, 2024

right now there's a .logLevel assignment in .getOptions. That means every call might switch the logging. We should think about a better way to handle all of this.

We should pass in a logger instance into rokuDeploy constructor to support this when devs want to make a custom instance.

Something like this?
image

@TwitchBronBron TwitchBronBron added this to the v4.0.0 milestone Mar 4, 2024
@TwitchBronBron TwitchBronBron changed the title Better logging handling in v4 Support scoped logging in v4 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants