Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support namespace style component interface function names #1268

Open
TwitchBronBron opened this issue Jul 29, 2024 · 0 comments
Open

Support namespace style component interface function names #1268

TwitchBronBron opened this issue Jul 29, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@TwitchBronBron
Copy link
Member

TwitchBronBron commented Jul 29, 2024

<interface>
  <function name="Namespace.FunctionName" />
  <field id="width" type="float" onchange="Namespace.FunctionName" />
</interface>

This should be supported. The validator should properly find these namespaced functions, and the transpiler should rewrite to Namespace_FunctionName.

For legacy reasons, we need to also still support Namespace_FunctionName as well.

Another situation we'll need to address is for completions and validations, we shouldn't allow Namespace.FunctionName when the project is pure brightscript. (we need to work this out)

@TwitchBronBron TwitchBronBron added enhancement New feature or request help wanted Extra attention is needed labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant