Adds List.last #816
Adds List.last #816
Conversation
| (list_var, Var(Symbol::ARG_1)), | ||
| ( | ||
| len_var, | ||
| // Num.sub (List.len list) 1 |
There was a problem hiding this comment.
This is the right approach for now, but actually we should use subWrap from #664 (once that's been implemented), because Num.sub should do overflow checking, and there's no chance of overflow yet.
(I say "should do" because currently only Num.add actually does it...maybe that's a good next project, actually!)
| @@ -282,6 +282,23 @@ mod repl_eval { | |||
| expect_success("List.sum [ 1.1, 2.2, 3.3 ]", "6.6 : F64"); | |||
| } | |||
|
|
|||
| // TODO add test cases for empty lists once error messages in the repl are correct | |||
There was a problem hiding this comment.
Sure enough! I've filed a bug for this: #818
| (list_var, Var(Symbol::ARG_1)), | ||
| ( | ||
| len_var, | ||
| // Num.sub (List.len list) 1 |
There was a problem hiding this comment.
This is the right approach for now, but actually we should use subWrap from #664 (once that's been implemented), because Num.sub should do overflow checking, and there's no chance of overflow yet.
(I say "should do" because currently only Num.add actually does it...maybe that's a good next project, actually!)
Adds List.last operation (see #664):
List.last : List elem -> Result elem [ ListWasEmpty ]*