Improve record field suffix warnings #7206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Records fields that allow effectful functions, should also accept pure functions.
jwoudenberg
reviewed
Nov 11, 2024
lukewilliamboswell
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently report a warning when we find a pure function in a
!-suffixed record literal field. However, we realized this doesn't make sense, because you might want a record field to allow effectful functions but not require them (example).This PR removes this warning for
!-suffixed record literal fields specifically, and it starts reporting it in annotations where it does make sense.Note: We still warn about unsuffixed record field literals with effectful functions.