Fixed roc format --stdin --stdout to format output
#6095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #6088 Signed-off-by: Becker A. <[email protected]>
rtfeldman
previously approved these changes
Nov 26, 2023
There was a problem hiding this comment.
@CrepeGoat This looks ready to merge to me!
I've approved it, but since it's still in Draft, I wasn't sure if you wanted to make any other changes before merging. 😄
|
Awesome, thanks for the review!
I have this in draft because I think I technically need an approval from my company (Google) to make this kind of open-source contribution. I’m not sure about the legal specifics but I don’t want to have any issues after merging in to main, and then having to surgically remove it from the repo because “no that’s our code”. Just trying to be safe out of an abundance of caution because big tech is big and sometimes scary.
I should get an approval this coming week, I’ll change this to a normal PR once that happens.
Thanks again!
Crepe
|
|
Got the OK -> should be good to merge on my end! Thanks again @rtfeldman 🙂 |
|
Don't worry about the test failures - something made it into |
Anton-4
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6088