Check in the language server #5937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ayaz <[email protected]>
Signed-off-by: Ayaz <[email protected]>
ayazhafiz
commented
Oct 25, 2023
Comment on lines
+147
to
+150
| pub trait IterTokens { | ||
| // Use a vec until "impl trait in trait" is stabilized | ||
| fn iter_tokens<'a>(&self, arena: &'a Bump) -> BumpVec<'a, Loc<Token>>; | ||
| } |
There was a problem hiding this comment.
When ITIT lands this will be 👨🏼🍳 💋 until then, we do this
ayazhafiz
commented
Oct 25, 2023
| work_done_progress_params: _, | ||
| } = params; | ||
|
|
||
| panic_wrapper(|| self.registry().hover(&text_document.uri, position)) |
There was a problem hiding this comment.
We still have compiler panics, so this is prudent.
rtfeldman
reviewed
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lands the current language server implementation.
At this time, the language server is a separate binary from the CLI, and moreover is not built automatically. When this branch lands, we can change that.