Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Abilities syntax #5745

Merged
merged 61 commits into from
Aug 11, 2023
Merged

New Abilities syntax #5745

merged 61 commits into from
Aug 11, 2023

Conversation

rtfeldman
Copy link
Contributor

@rtfeldman rtfeldman commented Aug 11, 2023 •
edited
Loading

This is just #5426 but with merge conflicts resolved, tests updated, etc. to get it over the finish line!

Note: in a separate PR, revert 254226f once this branch has landed and that branch has landed basic-cli!

@sandprickle
add word10 fn
0f289ed
@sandprickle
has clause -> implements clause
b1d592e
@sandprickle
has [abilities] -> implements [abilities]
d2fed03
@sandprickle
ast::Has -> ast::Implements
64c34a5
@sandprickle
ast::HasClause -> ast::ImplementsClause
ebbdae6
@sandprickle
ast::HasImpls -> ast::AbilityImpls
413ccb2
@sandprickle
ast::HasAbility -> ast::ImplementsAbility
9eb2180
@sandprickle
ast::HasAbilities -> ast::ImplementsAbilities
4b90948
@sandprickle
ast::ImplementsAbilities::Has ->
10d92bf 
ast::ImplementsAbilities::Implements
@sandprickle
has -> implements in comments
d700a6a
@sandprickle
loc_has -> loc_implements
46cb45f
@sandprickle
builtin opaque type abilites has -> implements
44d3396
@sandprickle
has -> implements in error messages
e04f092
@sandprickle
has -> implements in roc_problem::can::Problem
17c733e
@sandprickle
Fix typo
43e6cf6
@sandprickle
Update formatter has -> implements
95516d5
@sandprickle
has -> implements in reporting tests
8191c49
@sandprickle
has -> implements
31c06ca
@sandprickle
has [...] -> implements [...]
9bd2077
@sandprickle
use word instead of word10
2f5695e
@sandprickle
has [...] -> implements [...]
57c01de
@sandprickle
ident: "has" -> ident: "implements"
b05befd
@sandprickle
Identifier("has") -> Identifier("implements")
abb48e9
@sandprickle
"has" -> "implements"
3402683
@sandprickle
fix typo
55bb8f4
@sandprickle
abilities syntax has -> implements
91e3729
@sandprickle
abilities syntax has -> implements
dbc0204
@sandprickle
abilities syntax has -> implements in examples
3b1dbaf
@sandprickle
Re-enable test
d97d0c5
@sandprickle
has -> implements in comments
33c2b9d
@rtfeldman rtfeldman changed the title Abilities syntax New Abilities syntax Aug 11, 2023
Anton-4
Anton-4 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sandprickle and @rtfeldman :)

@Anton-4 Anton-4 enabled auto-merge August 11, 2023 14:16
@Anton-4 Anton-4 merged commit 743c4a7 into main Aug 11, 2023
10 checks passed
@Anton-4 Anton-4 deleted the abilities-syntax branch August 11, 2023 15:34
@Anton-4 Anton-4 mentioned this pull request Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anton-4 Anton-4 Anton-4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtfeldman @Anton-4 @sandprickle