Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs root link #5713

Merged
merged 3 commits into from
Jul 31, 2023
Merged

fix docs root link #5713

merged 3 commits into from
Jul 31, 2023

Conversation

Anton-4
Copy link
Collaborator

@Anton-4 Anton-4 commented Jul 31, 2023

The docs currently try to use a /Documentation link that does not work, this PR fixes that.

Comment on lines -146 to +147
"<!-- Package Name and Version -->",
render_name_and_version(package_name.as_str(), version.as_str()).as_str(),
"<!-- Package Name -->",
render_name_link(package_name.as_str()).as_str(),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't currently support extracting the version, so I've removed this for now.

@Anton-4 Anton-4 changed the title fix docs root link WIP fix docs root link Jul 31, 2023
@Anton-4 Anton-4 changed the title WIP fix docs root link fix docs root link Jul 31, 2023
Copy link
Contributor

@rtfeldman rtfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @Anton-4! 🎉

@Anton-4 Anton-4 merged commit ee88387 into main Jul 31, 2023
10 checks passed
@Anton-4 Anton-4 deleted the docs_link_fix branch July 31, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants