Reuse into tag #5625
Merged
Reuse into tag #5625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JTeeuwissen
reviewed
Jun 29, 2023
crates/compiler/mono/src/inc_dec.rs
Outdated
| @@ -1093,7 +1093,7 @@ fn insert_refcount_operations_binding<'a>( | |||
| } | |||
| } | |||
| } | |||
| Expr::Reuse { .. } | Expr::Reset { .. } | Expr::ResetRef { .. } => { | |||
| Expr::Reset { .. } | Expr::ResetRef { .. } => { | |||
| unreachable!("Reset(ref) and reuse should not exist at this point") | |||
There was a problem hiding this comment.
Suggested change
| unreachable!("Reset(ref) and reuse should not exist at this point") | |
| unreachable!("Reset(ref) should not exist at this point") |
JTeeuwissen
reviewed
Jun 29, 2023
crates/compiler/mono/src/ir.rs
Outdated
| @@ -7560,7 +7582,7 @@ fn substitute_in_expr<'a>( | |||
|
|
|||
| NullPointer => None, | |||
|
|
|||
| Reuse { .. } | Reset { .. } | ResetRef { .. } => { | |||
| Reset { .. } | ResetRef { .. } => { | |||
| unreachable!("reset/resetref/reuse have not been introduced yet") | |||
There was a problem hiding this comment.
Suggested change
| unreachable!("reset/resetref/reuse have not been introduced yet") | |
| unreachable!("reset(ref) has not been introduced yet") |
JTeeuwissen
reviewed
Jun 29, 2023
| @@ -1098,9 +1102,6 @@ fn expr_contains_symbol(expr: &Expr, needle: Symbol) -> bool { | |||
| }), | |||
There was a problem hiding this comment.
Don't forget to update Expr::Tag { arguments, .. } => arguments.contains(&needle), to check if the reuse token contains the symbol.
folkertdev
force-pushed
the
reuse-into-tag
branch
from
544b41b
to
0308e02
Compare
JTeeuwissen
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes the
Reuseexpr and instead uses areusefield onTag { .. }