Llvm 15 preparations #5614
Merged
Llvm 15 preparations #5614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayazhafiz
approved these changes
Jun 27, 2023
| @@ -166,7 +166,7 @@ fn gen_from_mono_module_llvm<'a>( | |||
|
|
|||
| let kind_id = Attribute::get_named_enum_kind_id("alwaysinline"); | |||
| debug_assert!(kind_id > 0); | |||
| let enum_attr = context.create_enum_attribute(kind_id, 1); | |||
| let enum_attr = context.create_enum_attribute(kind_id, 0); | |||
There was a problem hiding this comment.
Why does this need to change? Can we please lift the 0 to a constant? Here and below.
There was a problem hiding this comment.
well it needs to change because in llvm a value of 1 just does not work, and causes weird LLVM issues (the attribute is just invalid and llvm verification fails).
so, this is not a constant, the value has no meaning, and 0 just turns out to be ignored by llvm 15 (and 16). So I don't know what a constant would add here.
There was a problem hiding this comment.
also, this broke because it was never tested. I've opened a PR on inkwell to test these function attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some changes to make the llvm 15 upgrade easier