Formatting failure bug with if keyword likely introduced in #7060

[imclerran]

Looks like I've found a bug which was likely introduced with the formatting for early return if statements (#7060). I have a case where an assignment using if/then/else causes a formatting failure, and is being formatted with a hanging else in the debug output as though it were an early return:

setModels : Client, List Str -> Client
setModels = \client, models -> 
    modelsOption = if List.isEmpty models 
        then Option.none {}
        else Option.some models
    { client & models: modelsOption }

Causes a format failed bug, but gets formatted as the following in the debug output file:

setModels : Client, List Str -> Client
setModels = \client, models ->
    modelsOption = if
        List.isEmpty models
    then
        Option.none {}
        else

    Option.some models
    { client & models: modelsOption }

However, by moving the if onto a new line, formatting completes correctly. The following:

setModels : Client, List Str -> Client
setModels = \client, models -> 
    modelsOption = 
        if List.isEmpty models 
            then Option.none {}
            else Option.some models
    { client & models: modelsOption }

Formats as:

setModels : Client, List Str -> Client
setModels = \client, models ->
    modelsOption =
        if
            List.isEmpty models
        then
            Option.none {}
            else

        Option.some models
    { client & models: modelsOption }

This formatting still is incorrectly choosing the early return formatting style, even though this is assignment.

[imclerran]

Link to zulip convo here