Skip to content

Commit

Permalink
Merge pull request #5913 from roc-lang/dev-builds-lines-only
Browse files Browse the repository at this point in the history
default to `line-tables-only`
  • Loading branch information
rtfeldman committed Oct 17, 2023
2 parents 5940ae6 + 47d4335 commit 77d2136
Show file tree
Hide file tree
Showing 2 changed files with 66 additions and 45 deletions.
13 changes: 10 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -175,16 +175,23 @@ wyhash = "0.5.0"
# Optimizations based on https://deterministic.space/high-performance-rust.html
[profile.release]
codegen-units = 1

# debug = true # enable when profiling

[profile.dev]
debug = "line-tables-only"

[profile.bench]
codegen-units = 1
lto = "thin"

[profile.release-with-debug]
debug = true
inherits = "release"
debug = true

[profile.release-with-lto]
lto = "thin" # TODO: We could consider full here since this is only used for packaged release on github.
inherits = "release"
lto = "thin" # TODO: We could consider full here since this is only used for packaged release on github.

[profile.debug-full]
inherits = "dev"
debug = true
98 changes: 56 additions & 42 deletions crates/compiler/test_gen/src/helpers/dev.rs
Original file line number Diff line number Diff line change
Expand Up @@ -316,12 +316,6 @@ fn get_test_main_fn<T>(
get_raw_fn("test_main", lib)
}

pub(crate) fn run_function<T>(fn_name: &str, lib: &libloading::Library) -> T {
let main = get_raw_fn::<T>(fn_name, lib);

unsafe { main() }
}

pub(crate) fn run_test_main<T>(lib: &libloading::Library) -> Result<T, (String, CrashTag)> {
let main = get_test_main_fn::<T>(lib);

Expand All @@ -336,10 +330,58 @@ impl<T: Sized> From<RocCallResult<T>> for Result<T, (String, CrashTag)> {
}
}

// only used in tests
pub(crate) fn asm_evals_to<T, U, F>(
src: &str,
expected: U,
transform: F,
leak: bool,
lazy_literals: bool,
) where
U: PartialEq + std::fmt::Debug,
F: FnOnce(T) -> U,
{
use bumpalo::Bump;

let arena = Bump::new();
let (_main_fn_name, errors, lib) =
crate::helpers::dev::helper(&arena, src, leak, lazy_literals);

let result = crate::helpers::dev::run_test_main::<T>(&lib);

if !errors.is_empty() {
dbg!(&errors);

assert_eq!(
errors,
std::vec::Vec::new(),
"Encountered errors: {:?}",
errors
);
}

match result {
Ok(value) => {
let expected = expected;
#[allow(clippy::redundant_closure_call)]
let given = transform(value);
assert_eq!(&given, &expected, "output is different");
}
Err((msg, tag)) => match tag {
CrashTag::Roc => panic!(r#"Roc failed with message: "{msg}""#),
CrashTag::User => panic!(r#"User crash with message: "{msg}""#),
},
}
}

pub(crate) fn identity<T>(x: T) -> T {
x
}

#[allow(unused_macros)]
macro_rules! assert_evals_to {
($src:expr, $expected:expr, $ty:ty) => {{
assert_evals_to!($src, $expected, $ty, (|val| val));
assert_evals_to!($src, $expected, $ty, $crate::helpers::dev::identity);
}};
($src:expr, $expected:expr, $ty:ty, $transform:expr) => {
// Same as above, except with an additional transformation argument.
Expand All @@ -357,41 +399,13 @@ macro_rules! assert_evals_to {
}
};
($src:expr, $expected:expr, $ty:ty, $transform:expr, $leak:expr, $lazy_literals:expr) => {
use bumpalo::Bump;

let arena = Bump::new();
let (_main_fn_name, errors, lib) =
$crate::helpers::dev::helper(&arena, $src, $leak, $lazy_literals);

let result = $crate::helpers::dev::run_test_main::<$ty>(&lib);

if !errors.is_empty() {
dbg!(&errors);

assert_eq!(
errors,
std::vec::Vec::new(),
"Encountered errors: {:?}",
errors
);
}

match result {
Ok(value) => {
let expected = $expected;
#[allow(clippy::redundant_closure_call)]
let given = $transform(value);
assert_eq!(&given, &expected, "output is different");
}
Err((msg, tag)) => {
use roc_mono::ir::CrashTag;

match tag {
CrashTag::Roc => panic!(r#"Roc failed with message: "{msg}""#),
CrashTag::User => panic!(r#"User crash with message: "{msg}""#),
}
}
}
$crate::helpers::dev::asm_evals_to::<$ty, _, _>(
$src,
$expected,
$transform,
$leak,
$lazy_literals,
);
};
}

Expand Down

0 comments on commit 77d2136

Please sign in to comment.