Change record builder example to new syntax #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smores56
force-pushed
the
new-record-builder
branch
from
69af6f8
to
9b0299a
Compare
|
Go platform example is failing, as is documented in #207 |
lukewilliamboswell
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Wow, love this example. So simple and clearly explains the benefits of RecordBuilders. Thank you @smores56 😍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our record builder example was still using the old syntax for applicative record builders. With this PR, we will have removed all usages of old record builders from Roc repos, meaning we can remove support for old record builders from the language.