Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rebase] add AprilTagVision example #107

Merged
merged 10 commits into from
Jan 8, 2024

Conversation

Suave101
Copy link
Contributor

@Suave101 Suave101 commented Jan 8, 2024

This is the rebased and updated 2024 version of #100
The following image is the test I ran of the vision.py file:
image

- Added !/usr/bin/env python3 to the beginning of the file
- Added License to beginning of file
- Removed wpilib.run
- Reformated to black
@Suave101 Suave101 marked this pull request as ready for review January 8, 2024 02:46
@virtuald
Copy link
Member

virtuald commented Jan 8, 2024

did you try the example with a camera and tags in the image? My type checker is complaining about some things.

@virtuald
Copy link
Member

virtuald commented Jan 8, 2024

It didn't work, but I fixed it and verified that it detected some tags.

@virtuald virtuald merged commit e4aced8 into robotpy:main Jan 8, 2024
17 checks passed
@virtuald
Copy link
Member

virtuald commented Jan 8, 2024

There is a weird issue where it didn't detect tags when I had the 7 error correcting bits specified, but it worked when I removed that parameter. Since the Java example has that I'll keep it, maybe I did something wrong?

@Suave101 Suave101 deleted the 2024-add-AprilTagVision-Example branch January 8, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants