Add AxisCamera sample #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added AxisCamera to tests
Wrote bulk of vision code
virtuald
reviewed
Jan 4, 2024
AxisCamera/vision.py
Outdated
| # Get the Axis camera from CameraServer | ||
|
|
||
| camera = CameraServer.addAxisCamera("axis-camera.local") | ||
| # Set the resolution |
There was a problem hiding this comment.
Everything looks good, but can you associate the comments with the lines that they're with?
# Get the Axis camera from CameraServer
camera = CameraServer.addAxisCamera("axis-camera.local")
# Set the resolution
camera.setResolution(640, 480)
|
Please rebase and remove wpilib.run (see #106) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #49 Axis Camera Sample necessity! Could someone with a rio test the Axis Camera code because, I do not have a rio or an axis camera currently.