Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add easy to use preprocessor support #61

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Add easy to use preprocessor support #61

merged 1 commit into from
Aug 24, 2023

Conversation

virtuald
Copy link
Member

@tomazsustar let me know if this sufficiently addresses your concerns. I also have a version of this that will work with the web example too.

@virtuald virtuald merged commit acc2b27 into main Aug 24, 2023
24 checks passed
@virtuald virtuald deleted the preprocessor branch August 24, 2023 02:57
@tomazsustar
Copy link
Contributor

@virtuald I tested it and I like the approach. I had issues with _filter_self on windows, wich forced me to use retain_all_content=True.

In my example, the output of the preprocessor only contained a single file. The #line directive was with absolute path and the _filter_self was looking for a relative path with a few '../' prepended.

I think the #line directive should be parsed and converted to a relpath, so that we are allways comparing the same thing. Or both paths should be converted to an absolute path.

@virtuald
Copy link
Member Author

I don't have a windows machine nearby at the moment, but if you can provide the arguments you're providing to the functions I can try to reproduce. Or if you have a fix, that's great too.

We probably should make a testcase for this and add it to the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with preprocessor support disabled
2 participants