Syntax errors in features?

[ryanbugden]

There seem to be some errors and/or redundancies that, if one would go to generate again, makeotf complains about.

import extractor

path = 'SourceSerifPro-Regular.otf'

ufo = RFont(showInterface=True)
extractor.extractUFO(path, ufo)

gen = ufo.generate(
    "otfcff", 
    path.replace(".otf", "-2.otf"),
    )
    
print(gen)

e.g. the GDEF
syntax error at "]" [features 7]

e.g. redundancies

feature sinf {
    script latn;
    language AZE;
            script latn;
        language AZE;
        lookup SingleSubstitution12;

} sinf;

feature sinf {
    script latn;
    language AZE;
            script latn;
        language AZE;
        lookup SingleSubstitution12;

} sinf;

[typemytype]

extractor is not made to roundtrip...

how ever those features often cause problems

extractor uses https://github.com/simoncozens/fontFeatures to extract features