Notifications: reverse the dispatch order #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaseObject has a selfNotificationCallback that subscribes to all notifications of the object so to destroy representations. This should be called prior to any specific notification.
|
I'm fine with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseObject has a selfNotificationCallback that subscribes to all notifications of the object so to destroy representations. This should be called prior to any specific notification.
Reversing the dispatch order does that.
Note: this still means representations haven't been destroyed in the (None, None) and (None, observableRef) cases, but this change alleviates #102 for the more concrete cases.
r? @anthrotype
cc @typemytype