-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single object of type map passed keyword as argument give emtpy map as result after argument collection #33
Comments
I think there's still some confusion of kwargs in general, because RF own documentation states (implicitly) that single map can't be treated as kwarg from caller side
According your use case you just want to use argument as type of map, not kwargs. |
Correct! I want to use the Map as normal arg but somehow it doesnt get parsed! |
OK, I think now I started to see the issue. Not sure if I have time to check it within this week, but I'll try. Probably it requires new version from both JavalibCore and jrobotremoteserver, but let see. |
Ok. If you need, you can go through my PR I will be adding few more test cases in it |
Just remembered this, and noticed that there's a test that should check for that ( JavalibCore/src/test/java/org/robotframework/javalib/library/AnnotationLibraryIntegrationTest.java Line 127 in c649b8d
So I'm still a bit puzzled of the issue. Note that this needs annotations to work. With Classpathlibrary approach map is always varargs, and I don't think there's any reason to try to make any logic to try to determine if user wants to use arg or varargs. |
Coming from #19 and robotframework documentation as java has no support for explicit kwarg variable, a single map passed on to robot keyword without
**
must also be considered as kwarg.In
KeywordInvoker.java
andArgumentCollector.java
while collecting argumentsargs
is not null with one non empty map butkwargs
are null. But after keyword argument collection we receive one empty map which is wrongThe text was updated successfully, but these errors were encountered: