Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move proto definitions to separate repo #139

Open
TarikViehmann opened this issue Dec 11, 2022 · 2 comments
Open

Move proto definitions to separate repo #139

TarikViehmann opened this issue Dec 11, 2022 · 2 comments

Comments

@TarikViehmann
Copy link
Contributor

Having a separate repo for proto messages allows all communicators (refbox, simulations, team servers, robots) to integrate that repo as a submodule.

@pkohout
Copy link
Contributor

pkohout commented Dec 14, 2022

@TarikViehmann if you create an empty repository I would be up to move the proto messages there and setup up a GitHub action that builds a deb file, so that teams can simply install them via apt.

@pkohout
Copy link
Contributor

pkohout commented Jan 13, 2023

I tested our dockerfile for the webshop we used back in the day, this is not building anymore because the clips-rest-api does not build. I guess since the webshop will only need the refbox messages we could get rid of it once we move them to an empty repo.


      --> Entering sub-directory rest-api ---
         --- Compiling webview_server.cpp (C++)
         --- Compiling service_browse_handler.cpp (C++)
         --- Compiling rest_processor.cpp (C++)
         --- Compiling clips-rest-api/clips-rest-api.cpp (C++)
         --- Compiling clips-rest-api/model/Fact.cpp (C++)
         --- Compiling clips-rest-api/model/SlotValue.cpp (C++)
         --- Compiling clips-rest-api/model/RingSpec.cpp (C++)
         --- Compiling clips-rest-api/model/Robot.cpp (C++)
/root/rcll-refbox/src/libs/rest-api/clips-rest-api/clips-rest-api.cpp: In member function ‘Fact llsfrb::ClipsRestApi::gen_fact(CLIPS::Fact::pointer&, bool)’:
/root/rcll-refbox/src/libs/rest-api/clips-rest-api/clips-rest-api.cpp:179:96: error: ISO C++ forbids converting a string constant to ‘char*’ [-Werror=write-strings]
   PrintFact(env_->cobj(), (const char *)"ProcPPForm", (struct fact *)fact->cobj(), FALSE, FALSE);
                                                                                                ^
         --- Compiling clips-rest-api/model/Environment.cpp (C++)
         === Linking lib libllsf_protobuf_clips ---
         --- Compiling clips-rest-api/model/Points.cpp (C++)
         <-- Leaving protobuf_clips
         --- Compiling clips-rest-api/model/GameState.cpp (C++)
         --- Compiling clips-rest-api/model/Order.cpp (C++)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants