Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other data types. #8

Open
krzentner opened this issue Jan 2, 2019 · 2 comments
Open

Support other data types. #8

krzentner opened this issue Jan 2, 2019 · 2 comments

Comments

@krzentner
Copy link
Contributor

Currently, all of the spaces assume that the datatype is np.float32. However, some environments use e.g. np.uint8. We should support that.

See garage PR 455.

@sud0nick
Copy link
Contributor

@krzentner is this still an issue? It appears Box is the only class that takes a dtype in the constructor and there is code to support np.float32 and np.uint8. However, all of the tensorflow converters assume a dtype of tf.uint8. Let me know if those should change to support tf.float32 as well.

@krzentner
Copy link
Contributor Author

This is still an issue, although not a very high priority one. akro.Tuple actually uses np.core.numerictypes.find_common_type to find the common dtype. It would be good to preserve that behavior, and spread it to akro.Dict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants