Use blocksize to determine size for rz_cmd_disassembly_n_bytes_handler() #4714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Commands like pD are accepts optional argument, but rz_cmd_disassembly_n_bytes_handler() requires it. Add current core->blocksize as failback to help calculating correct size.
Test plan
Current dev threats no args
pD
as error, but rizin book andpD?
states that should be correct command:After applied changes
pD
should correctly dump file without optional argument:Closing issues
...