Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NetBSD 10 build #4524

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Fix NetBSD 10 build #4524

merged 2 commits into from
Jun 1, 2024

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Jun 1, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr is a blind fix just to make the NetBSD build go green. Theoretically, the fix makes sense based on an examination of current code and the following web pages:

but no manual testing has been done and I don't think there are any automated tests either.

Test plan

All builds are green.

Closing issues

Closes #4523.

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. As for debug tests it's a long standing issue: #3072
Ideally, we should refactor our native debugger first, but given that RzArch and RzIL refactorings are now planned, it will not happen any time soon.

@kazarmy kazarmy merged commit 5129fdb into dev Jun 1, 2024
35 of 41 checks passed
@kazarmy kazarmy deleted the bsd-netbsd-10-ptrace branch June 1, 2024 15:34
@kazarmy kazarmy mentioned this pull request Jun 1, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetBSD CI build is broken
2 participants