Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sdb from rz_util_includes #3937

Closed
wants to merge 1 commit into from
Closed

Remove sdb from rz_util_includes #3937

wants to merge 1 commit into from

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Oct 23, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr just removes sdb from rz_util_includes since there's nothing in the referred directory that is includable, and #include <src/...> looks weird.

Test plan

All builds are green.

Closing issues

...

XVilka
XVilka approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM it green

@ret2libc
Copy link
Member

Please use dist- branches for these kind of changes because they also test that the installation of rizin can be used as a base for development (e.g. headers are correctly installed, used, etc.)

@kazarmy
Copy link
Member Author

kazarmy commented Oct 23, 2023

Ok, see #3938

@kazarmy kazarmy closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

Assignees
No one assigned
Labels
RzUtil
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kazarmy @ret2libc @XVilka