Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Capstone 3 (fix CS 4 & 5) #3933

Closed
wants to merge 5 commits into from
Closed

Remove Capstone 3 (fix CS 4 & 5) #3933

wants to merge 5 commits into from

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Oct 20, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Addresses #3210

Since it is on a dist branch, this PR will also fix the bugs introduced with ARM and PPC CS v6 merge.

Test plan

All green.

Closing issues

closes #3210

@github-actions github-actions bot added the PPC label Oct 20, 2023
XVilka
XVilka approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why draft?

@Rot127
Copy link
Member Author

Rot127 commented Oct 21, 2023 •
edited
Loading

@XVilka I wanted to make sure everything is green before notifying everyone.

Besides that, the CI workflows are broken for CS v4 and v5 (sys?). They test nothing. Would add them here as well.

Never mind. Should have capstone in the branch name.

@Rot127
Copy link
Member Author

Rot127 commented Oct 21, 2023

Superseded by #3934

@Rot127 Rot127 closed this Oct 21, 2023
@Rot127 Rot127 deleted the dist-remove-cs3 branch July 28, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

@wargio wargio Awaiting requested review from wargio wargio will be requested when the pull request is marked ready for review wargio is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy will be requested when the pull request is marked ready for review kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r will be requested when the pull request is marked ready for review thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc will be requested when the pull request is marked ready for review ret2libc is a code owner

Assignees
No one assigned
Labels
ARM infrastructure MIPS PPC RzAnalysis X86
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Capstone 3 support
2 participants
@Rot127 @XVilka